fix(#1787): post inline comments for COMMENT review verdicts#1792
fix(#1787): post inline comments for COMMENT review verdicts#1792fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
The COMMENT early-return in submitFormalReview() was placed before inline comment assembly, unconditionally skipping inline findings even when they had valid file+line locations within PR diff hunks. Move the COMMENT early-return after findingsToReviewComments() and gate it on len(inlineComments) == 0. When inline-eligible findings exist, submit a formal COMMENT review with the inline comments attached and a body linking to the sticky comment (matching the REQUEST_CHANGES pattern). When no findings are inline-eligible, retain the existing skip behavior. Tests added: - CommentSubmittedWithInlineFindings: COMMENT verdict with in-diff findings creates a formal review with inline comments - CommentSkippedWhenFindingsFilteredOut: COMMENT verdict where all findings are outside the diff still skips the formal review Note: pre-commit could not run in sandbox (Go toolchain permission denied). The post-script will run it authoritatively. Closes #1787
Site previewPreview: https://6f17449d-site.fullsend-ai.workers.dev Commit: |
ReviewFindingsMedium
Info
|
The COMMENT early-return in submitFormalReview() was placed before inline comment assembly, unconditionally skipping inline findings even when they had valid file+line locations within PR diff hunks.
Move the COMMENT early-return after findingsToReviewComments() and gate it on len(inlineComments) == 0. When inline-eligible findings exist, submit a formal COMMENT review with the inline comments attached and a body linking to the sticky comment (matching the REQUEST_CHANGES pattern). When no findings are inline-eligible, retain the existing skip behavior.
Tests added:
in-diff findings creates a formal review with inline comments
all findings are outside the diff still skips the formal review
Note: pre-commit could not run in sandbox (Go toolchain permission denied). The post-script will run it authoritatively.
Closes #1787
Post-script verification
agent/1787-comment-inline-comments)74e81270842f6976b3f6a8514aaa925d84d0d3be..HEAD)