fix(#1734): scope mint token to enabled repos only in repo-maintenance#1756
Open
rh-hemartin wants to merge 1 commit into
Open
fix(#1734): scope mint token to enabled repos only in repo-maintenance#1756rh-hemartin wants to merge 1 commit into
rh-hemartin wants to merge 1 commit into
Conversation
Extract enrolled repo names filters .repos | keys, passing all repos (enabled and disabled) to mint-token. GitHub returns 422 when the requested repos list includes repos not covered by the app installation. Filter to enabled: true only, matching reconcile-repos.sh behaviour. Closes #1734 Signed-off-by: Hector Martinez <hemartin@redhat.com>
Site previewPreview: https://d5cebe2c-site.fullsend-ai.workers.dev Commit: |
ReviewFindingsNo findings. Previous runReviewFindingsNo findings. |
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
fullsend-ai-review
Bot
added
the
ready-for-merge
Contributor
|
/fs-review |
fullsend-ai-review
Bot
added
ready-for-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
repo-maintenance.ymlpassed all repos (enabled + disabled) tomint-token, causing GitHub to return 422 when disabled repos aren't covered by the app installationenabled: trueonly, matching the behaviour ofreconcile-repos.shTest plan
yqexpression returns only enabled repos:yq '[.repos | to_entries[] | select(.value.enabled == true) | .key] | join(",")' config.yamlrepo-maintenanceon a.fullsendrepo that has disabled repos — confirm no 422 from mintCloses #1734
🤖 Generated with Claude Code