fix(ci): correct reusable-dispatch stage skip expression

[ifireball]

Summary

• Fixes the route job stage output in .github/workflows/reusable-dispatch.yml so per-repo silent-skip works when a routed stage's role is not in defaults.roles.
• Replaces skipped == 'true' && '' || stage (always evaluates to stage because '' is falsy in GHA) with skipped != 'true' && stage || ''.

Fixes #1199

Test plan

• On a per-repo install, trigger dispatch for a stage whose mapped role is not in .fullsend/config.yaml roles — route should output empty stage and all stage jobs should be skipped.
• Trigger dispatch for a configured role — stage jobs should still run as before.

Made with Cursor

[github-actions]

Site preview

Preview: https://4a204e0c-site.fullsend-ai.workers.dev

Commit: 1efe7cbd2b19a411fe93dee157439f455c2e1feb

[fullsend-ai-review]

Review

Findings

Medium

• [protected-path] .github/workflows/reusable-dispatch.yml — This PR modifies a file under .github/, which is a protected path requiring human approval. The change is well-justified (fixes Merged PR contains broken GHA expression that defeats the silent-skip feature #1199, restoring broken silent-skip behavior), but human review is required for all protected-path changes regardless of context.

Low

• [docs-staleness] docs/superpowers/plans/2026-05-15-silent-skip-unconfigured-roles.md:179 — The plan document contains the buggy expression (skipped == 'true' && '' || steps.route.outputs.stage) that this PR fixes. Since this is a historical plan document rather than a user guide, the staleness is low impact, but updating line 179 to reflect the corrected expression would keep the plan accurate for future reference.

Info

• [correctness] .github/workflows/reusable-dispatch.yml:52 — The fix is correct. In GHA expressions, &&/|| return operand values (like JavaScript short-circuit evaluation). The old expression skipped == 'true' && '' || stage always evaluated to stage because true && '' yields '' (falsy), which falls through via || to stage. The new expression skipped != 'true' && stage || '' correctly places the truthy value (stage) in the if-true position, so the ternary pattern works as intended. This is consistent with the same skipped != 'true' pattern already used on line 278.

[rh-hemartin]

It does look like this does not produce a string output, it seems like it would produce a boolean. If it is bash then I guess this makes sense but I'm not sure. If you are confident this does what it is supposed to do, then go ahead.

[ralphbean]

The \!= does produce a boolean, but GHA short-circuit semantics keep it from leaking into the output. When skipped is 'true': false && stage short-circuits to false, then false || '' yields ''. When skipped isn't 'true': true && stage yields the stage string (e.g. 'review'), then 'review' || '' yields 'review'. So the final value is always either the stage string or empty — the intermediate boolean never reaches the output.

[ralphbean]

For reference, the GHA expression evaluator source confirms && and || return operand values, not booleans — same semantics as JavaScript:

visitLogical(logical: Logical): data.ExpressionData {
  let result: data.ExpressionData;
  for (const arg of logical.args) {
    result = this.eval(arg);
    if (
      (logical.operator.type === TokenType.AND && falsy(result)) ||
      (logical.operator.type === TokenType.OR && truthy(result))
    ) {
      break;
    }
  }
  return result!;
}

[ifireball]

@ralphbean @rh-hemartin @ascerra can we merge this or should we wait until after Wednesday?