Skip to content

Change BouncyCastle library from Portable.BouncyCastle to BouncyCastl… #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arkadiuszwojcik wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Change BouncyCastle library from Portable.BouncyCastle to BouncyCastl… #324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Certes/Certes.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="Newtonsoft.Json" Version="13.0.2" />
<PackageReference Include="Portable.BouncyCastle" Version="1.9.0" />
<PackageReference Include="BouncyCastle.Cryptography" Version="2.3.0" />
<PackageReference Include="System.ValueTuple" Version="4.5.0" Condition="'$(TargetFramework)' == 'net462'" />
</ItemGroup>

Expand Down
8 changes: 3 additions & 5 deletions src/Certes/Pkcs/PfxBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ private IList<X509Certificate> FindIssuers()
Cert = cert
});

var rootCerts = new HashSet(certificates.Where(c => c.IsRoot).Select(c => new TrustAnchor(c.Cert, null)));
var rootCerts = new HashSet<TrustAnchor>(certificates.Where(c => c.IsRoot).Select(c => new TrustAnchor(c.Cert, null)));
var intermediateCerts = certificates.Where(c => !c.IsRoot).Select(c => c.Cert).ToList();
intermediateCerts.Add(certificate);

Expand All @@ -125,10 +125,8 @@ private IList<X509Certificate> FindIssuers()
IsRevocationEnabled = false
};

builderParams.AddStore(
X509StoreFactory.Create(
"Certificate/Collection",
new X509CollectionStoreParameters(intermediateCerts)));
var x509CertStore = CollectionUtilities.CreateStore(intermediateCerts);
builderParams.AddStoreCert(x509CertStore);

var builder = new PkixCertPathBuilder();
var result = builder.Build(builderParams);
Expand Down