Add mixed pattern in gcsfs microbenchmarks#822
Open
googlyrahman wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #822 +/- ##
==========================================
+ Coverage 79.55% 81.43% +1.88%
==========================================
Files 16 16
Lines 3042 3076 +34
==========================================
+ Hits 2420 2505 +85
+ Misses 622 571 -51 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1419abf to
10676f9
Compare
zhixiangli
requested changes
Apr 23, 2026
zhixiangli
approved these changes
Apr 24, 2026
jasha26
approved these changes
Apr 27, 2026
Collaborator
|
Can you please fix the test failure so its ready for merge |
Collaborator
Author
|
Aah this needs to rebased with main to fix the failure, let me do it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The read benchmarks in our microbenchmarks are either (100% sequential 0% seek) or (0% sequential 100% seek) with fixed io size. These are often not correct representation of real world scenarios.
Real world scenarios are mixed of sequential, and seeks with a variable of
iosize. The following PR add this feature in microbenchmarks to correctly measure the typical real world performance.Sample output after this PR