Fix infinite recursion in expand_path when resolving paths with glob magic characters (#2036)#2038
Merged
Merged
Conversation
martindurant
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When calling expand_path(or the async _expand_path) with recursive=True on paths that resolve to filenames containing glob magic characters (such as [ or ?), the method would incorrectly treat these resolved paths as new glob patterns in the next recursive step. This led to either infinite recursion or unexpected FileNotFoundError when the characters were interpreted as character classes (e.g., file[1].txt searching for file1.txt).
To prevent this, assume_literal parameter is introduced to both expand_path and _expand_path:
Fixes #2036