Skip to content

[Repo Assist] perf: pre-compute hasOutputParameters flag at construction time #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
github-actions wants to merge 2 commits into from
Closed

[Repo Assist] perf: pre-compute hasOutputParameters flag at construction time #478

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f9f7b5
perf: pre-compute hasOutputParameters flag at construction time
github-actions[bot] Mar 16, 2026
b122de9
ci: trigger checks
github-actions[bot] Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 17 additions & 13 deletions src/SqlClient/ISqlCommand.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,11 @@ type ``ISqlCommand Implementation``(cfg: DesignTimeConfig, connection: Connectio

let notImplemented _ : _ = raise <| NotImplementedException()

// Pre-compute whether any parameters are output parameters once at construction time,
// avoiding repeated Seq.cast + Seq.exists traversal on every Execute call.
let hasOutputParameters =
cfg.Parameters |> Array.exists (fun p -> p.Direction.HasFlag(ParameterDirection.Output))

let execute, asyncExecute, executeSingle, asyncExecuteSingle =
match cfg.ResultType with
| ResultType.DataReader ->
Expand All @@ -102,7 +107,7 @@ type ``ISqlCommand Implementation``(cfg: DesignTimeConfig, connection: Connectio
| ResultType.Records | ResultType.Tuples ->
match box cfg.RowMapping, cfg.ItemTypeName with
| null, null ->
``ISqlCommand Implementation``.ExecuteNonQuery manageConnection >> box,
``ISqlCommand Implementation``.ExecuteNonQuery manageConnection hasOutputParameters >> box,
``ISqlCommand Implementation``.AsyncExecuteNonQuery manageConnection >> box,
notImplemented,
notImplemented
Expand All @@ -120,9 +125,9 @@ type ``ISqlCommand Implementation``(cfg: DesignTimeConfig, connection: Connectio
.GetMethod("AsyncExecuteSeq", BindingFlags.NonPublic ||| BindingFlags.Static)
.MakeGenericMethod(itemType)

executeHandle.Invoke(null, [| cfg.Rank; cfg.RowMapping |]) |> unbox >> box,
executeHandle.Invoke(null, [| cfg.Rank; cfg.RowMapping; hasOutputParameters |]) |> unbox >> box,
asyncExecuteHandle.Invoke(null, [| cfg.Rank; cfg.RowMapping |]) |> unbox >> box,
executeHandle.Invoke(null, [| ResultRank.SingleRow; cfg.RowMapping |]) |> unbox >> box,
executeHandle.Invoke(null, [| ResultRank.SingleRow; cfg.RowMapping; hasOutputParameters |]) |> unbox >> box,
asyncExecuteHandle.Invoke(null, [| ResultRank.SingleRow; cfg.RowMapping |]) |> unbox >> box

| unexpected -> failwithf "Unexpected ResultType value: %O" unexpected
Expand Down Expand Up @@ -298,9 +303,7 @@ type ``ISqlCommand Implementation``(cfg: DesignTimeConfig, connection: Connectio
return result
}

static member internal ExecuteSeq<'TItem> (rank, rowMapper) = fun(cmd: SqlCommand, getReaderBehavior, parameters, expectedDataReaderColumns) ->
let hasOutputParameters = cmd.Parameters |> Seq.cast<SqlParameter> |> Seq.exists (fun x -> x.Direction.HasFlag( ParameterDirection.Output))

static member internal ExecuteSeq<'TItem> (rank, rowMapper, hasOutputParameters: bool) = fun(cmd: SqlCommand, getReaderBehavior, parameters, expectedDataReaderColumns) ->
if not hasOutputParameters
then
let xs = Seq.delay <| fun() ->
Expand Down Expand Up @@ -360,16 +363,17 @@ type ``ISqlCommand Implementation``(cfg: DesignTimeConfig, connection: Connectio
assert (rank = ResultRank.Sequence)
box xs

static member internal ExecuteNonQuery manageConnection (cmd, _, parameters, _) =
static member internal ExecuteNonQuery manageConnection hasOutputParameters (cmd, _, parameters, _) =
``ISqlCommand Implementation``.SetParameters(cmd, parameters)
use openedConnection = cmd.Connection.UseLocally(manageConnection )
let recordsAffected = cmd.ExecuteNonQuery()
for i = 0 to parameters.Length - 1 do
let name, _ = parameters.[i]
let p = cmd.Parameters.[name]
if p.Direction.HasFlag( ParameterDirection.Output)
then
parameters.[i] <- name, p.Value
if hasOutputParameters then
for i = 0 to parameters.Length - 1 do
let name, _ = parameters.[i]
let p = cmd.Parameters.[name]
if p.Direction.HasFlag( ParameterDirection.Output)
then
parameters.[i] <- name, p.Value
recordsAffected

static member internal AsyncExecuteNonQuery manageConnection (cmd, _, parameters, _) =
Expand Down
Loading