Skip to content

[Repo Assist] fix: exclude computed columns from BulkCopy column mappings (Closes #272) #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
github-actions wants to merge 2 commits into from
Closed

[Repo Assist] fix: exclude computed columns from BulkCopy column mappings (Closes #272) #472

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2dbcd82
fix: exclude computed columns from BulkCopy column mappings (Closes #…
github-actions[bot] Mar 15, 2026
f477045
ci: trigger checks
github-actions[bot] Mar 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/SqlClient/DataTable.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,13 @@ type DataTable<'T when 'T :> DataRow>(selectCommand: SqlCommand, ?connectionStri
bulkCopy.DestinationTableName <- this.TableName
batchSize |> Option.iter bulkCopy.set_BatchSize
timeout |> Option.iter (fun x -> bulkCopy.BulkCopyTimeout <- int x.TotalSeconds)
// Exclude computed columns (ReadOnly=true, AutoIncrement=false) because SQL Server
// rejects writes to computed columns. Also exclude identity columns unless the
// caller explicitly opted in with KeepIdentity.
let keepIdentity = options.HasFlag(SqlBulkCopyOptions.KeepIdentity)
for col in this.Columns |> Seq.cast<DataColumn> do
if not col.ReadOnly || (col.AutoIncrement && keepIdentity) then
bulkCopy.ColumnMappings.Add(col.ColumnName, col.ColumnName) |> ignore
bulkCopy.WriteToServer this

#if WITH_LEGACY_NAMESPACE
Expand Down
Loading