Skip to content

[Repo Assist] fix: resolve FSharp.Core version mismatch in item type resolution (Closes #433) #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smoothdeveloper merged 2 commits into from
Mar 16, 2026
Merged

[Repo Assist] fix: resolve FSharp.Core version mismatch in item type resolution (Closes #433) #471

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f1cda3
fix: resolve FSharp.Core version mismatch in item type resolution (Cl…
github-actions[bot] Mar 15, 2026
33ed1ea
ci: trigger checks
github-actions[bot] Mar 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion src/SqlClient/ISqlCommand.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ open System
open System.Data
open System.Data.SqlClient
open System.Reflection
open System.Text.RegularExpressions
open FSharp.Data.SqlClient
open FSharp.Data.SqlClient.Internals
open System.Linq
Expand All @@ -33,6 +34,23 @@ module Seq =
| [| x |] -> Some x
| _ -> invalidArg "source" "The input sequence contains more than one element."

module internal TypeResolution =

// Resolves a type by its assembly-qualified name, with a version-tolerant fallback.
// The design-time DLL runs inside the F# compiler process and bakes the compiler's FSharp.Core
// version into item type names. If the user's project references a different FSharp.Core version,
// Type.GetType with the exact name fails with FileLoadException. Stripping version/culture/token
// from the assembly reference lets the runtime's binding logic find the correct assembly.
// See: https://github.com/fsprojects/FSharp.Data.SqlClient/issues/433
let resolveType (typeName: string) =
match Type.GetType(typeName, throwOnError = false) with
| null ->
let stripped = Regex.Replace(typeName, @",\s*Version=[^,\[\]]+", "")
let stripped = Regex.Replace(stripped, @",\s*Culture=[^,\[\]]+", "")
let stripped = Regex.Replace(stripped, @",\s*PublicKeyToken=[^,\[\]]+", "")
Type.GetType(stripped, throwOnError = true)
| t -> t

[<CompilerMessageAttribute("This API supports the FSharp.Data.SqlClient infrastructure and is not intended to be used directly from your code.", 101, IsHidden = true)>]
type RowMapping = obj[] -> obj

Expand Down Expand Up @@ -108,7 +126,7 @@ type ``ISqlCommand Implementation``(cfg: DesignTimeConfig, connection: Connectio
notImplemented
| rowMapping, itemTypeName ->
assert ((not(isNull rowMapping)) && (not (isNull itemTypeName)))
let itemType = Type.GetType( itemTypeName, throwOnError = true)
let itemType = TypeResolution.resolveType itemTypeName

let executeHandle =
typeof<``ISqlCommand Implementation``>
Expand Down
Loading