Conversation
…or known breaking changes Activates binary compatibility checking against the last published release (v0.4.0) by uncommenting PackageValidationBaselineVersion in the project file. The build revealed 3 existing API breaks between 0.4.0 and 0.6.0-dev — all in compiler-internal F# witness infrastructure that is technically public but not intended for direct user consumption: - TaskSeqBuilder.Bind<...> (internal CE overload) - TaskSeqBuilder.Bind$W<...> (F# witness-passing variant, compiler-generated) - TaskExtensions.TaskBuilder.For<...> (for-in-IAsyncEnumerable overload) These suppressions are recorded in CompatibilitySuppressions.xml. All future inadvertent API breaks will now be caught automatically during dotnet build. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
6 tasks
dsyme
approved these changes
Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This is a draft PR from Repo Assist, an automated AI assistant.
Activates binary compatibility checking against the last published release (
v0.4.0) by uncommentingPackageValidationBaselineVersionin the project file.EnablePackageValidationwas already enabled (added in PR #315), but without a baseline version only structural package validation ran — no cross-version binary compatibility check.What this enables
With
PackageValidationBaselineVersion=0.4.0, everydotnet buildand CI run now automatically verifies that all public APIs present inFSharp.Control.TaskSeq 0.4.0are still present in the current version with compatible signatures. Any future inadvertent breaking change will produce a build error rather than being silently shipped.What it found
Running the check immediately revealed 3 existing API breaks between
0.4.0and the current0.6.0-dev. All three are in compiler-internal F# CE infrastructure — technically public members but not intended for direct user consumption:FSharp.Control.LowPriority.TaskSeqBuilder.Bind<...>BindoverloadFSharp.Control.LowPriority.TaskSeqBuilder.Bind$W<...>FSharp.Control.TaskExtensions.TaskBuilder.For(T,TOverall)for x in IAsyncEnumerableoverload fortask {}These are suppressed in the new
CompatibilitySuppressions.xmlfile (standard .NET SDK mechanism). The suppression file format is documented at (learn.microsoft.com/redacted)Files changed
FSharp.Control.TaskSeq.fsproj: uncommentPackageValidationBaselineVersionCompatibilitySuppressions.xml: suppress 3 known compiler-internal breaking changes (new file)release-notes.txt: document engineering changeTest Status
✅ Build (Release): succeeded, 0 warnings, 0 errors
✅ Package validation: passes with suppression file
✅ No code changes — library logic is unmodified