[Repo Assist] feat: add TaskSeq.allPairs (69 tests)#333
Draft
github-actions[bot] wants to merge 2 commits intomainfrom
Draft
[Repo Assist] feat: add TaskSeq.allPairs (69 tests)#333github-actions[bot] wants to merge 2 commits intomainfrom
github-actions[bot] wants to merge 2 commits intomainfrom
Conversation
Implements TaskSeq.allPairs which returns all pairings of elements from two task sequences. source2 is fully materialised before iteration begins; source1 is consumed lazily. - TaskSeqInternal.fs: allPairs implementation (materialises source2 via toResizeArrayAsync) - TaskSeq.fs / .fsi: public API with XML documentation - TaskSeq.AllPairs.Tests.fs: 69 new tests - README.md: mark allPairs as implemented - release-notes.txt: updated Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This is a draft PR from Repo Assist, an automated AI assistant.
Implements
TaskSeq.allPairs, which returns a task sequence of all pairings of elements from two input task sequences — matching the behaviour ofSeq.allPairs.API
Formatting verified with
dotnet fantomas . --check— no issues.Design notes
source2must be pre-materialised because it is iterated once per element ofsource1. The XML doc makes this explicit.Seq.allPairsworks: nested iteration with the outer loop oversource1.taskSeqexpression.source1is never materialised, soallPairsworks correctly on infinite sequences assource1.