ci: cover btc-embedded + dash-spv-embedded, un-gate qt build, add BTC smoke#45
Open
frstrtr wants to merge 1 commit into
Open
ci: cover btc-embedded + dash-spv-embedded, un-gate qt build, add BTC smoke#45frstrtr wants to merge 1 commit into
frstrtr wants to merge 1 commit into
Conversation
- push/PR triggers now cover btc-embedded and dash-spv-embedded. Previously only PRs to master triggered CI on those branches; direct pushes to either branch had no coverage at all. - qt-webengine job no longer gated by `if: false`. Configure + Build steps run unconditionally (catches PageEmbedded API breakage). The runtime mount/destroy x100 step is marked continue-on-error so the known QtWebEngine 6.4.2 + GPU-less-runner SIGSEGV doesn't block merges while still surfacing if a future Qt bump fixes it. - New btc-linux job builds c2pool-btc target as smoke coverage for the embedded BTC SPV binary. Gated to runs where btc-embedded is the push ref, PR head, or PR base — no-op on master itself (where the BTC sources don't exist). Activates when this workflow flows into btc-embedded via merge. BTC previously had zero automated coverage. share_test.cpp and template_parity_test.cpp under src/impl/btc/test/ are deferred to a follow-up on btc-embedded that re-enables add_subdirectory(test) and gives template_parity proper CMake plumbing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI extension to plug three coverage gaps flagged in the ci-steward reassignment:
pushandpull_requestnow includebtc-embeddedanddash-spv-embeddedalongsidemaster/windows-build/service-update. Direct pushes to those feature branches previously ran no CI; only PRs targeting master triggered (and PR Dash mainnet readiness: embedded GBT + Phase C complete + interop fixes #43 had been open 30+ days under that limitation).if: false. Configure + Build steps now run on every CI invocation, so any API breakage inPageEmbedded::destroyViewor its Qt deps fails compile and gates the merge. The mount/destroy×100 runtime step keeps the known QtWebEngine 6.4.2 + GPU-less-runner SIGSEGV from blocking by marking itcontinue-on-error: true— when Ubuntu PPA eventually ships Qt 6.6+ or a self-hosted runner lands, drop that flag to re-promote it to gating.c2pool-btctarget as a smoke. Gated to refs wherebtc-embeddedis involved (push ref, PR head, or PR base), so it's a no-op on master itself (the BTC sources don't exist there yet) and activates as soon as this workflow lands on btc-embedded via merge. Until now, BTC had zero automated coverage on any commit.Deferred (out of scope, follow-up PR on btc-embedded)
src/impl/btc/test/share_test.cpp—add_subdirectory(test)is commented out insrc/impl/btc/CMakeLists.txtbecause the test still references LTC types; revival is owned by the btc-heap-opt arc.src/impl/btc/test/template_parity_test.cpp— the file header claims a standaloneg++build works, but transitive includes pull in nlohmann_json / leveldb_store / core/log. Needs a proper CMake target rather than ad-hoc compile flags in CI.Test plan
ci/extension-multi-branch).btc-embeddedanddash-spv-embeddedso direct pushes to those branches start triggering CI immediately, or wait for the next master-merge flow.btc-linuxgate flips active andcmake --build --target c2pool-btcruns on every push/PR there.Coordination
btc-heap-opt-2026-05ownssrc/c2pool/main_btc.cppandsrc/impl/btc/share_tracker.hpp— this PR doesn't touch either.dash-consensus-pay-replayownstest/test_dash_*— none of those test targets exist on master's build.yml yet (they land via PR Dash mainnet readiness: embedded GBT + Phase C complete + interop fixes #43), so this PR doesn't restructure them.Do not merge without integrator sign-off (per [handoff] policy).