Skip to content

ci(renovate): update Node.js Docker rule with semver release notes#684

Merged
marcusrbrown merged 1 commit into
mainfrom
plum-outstanding-giraffe
May 28, 2026
Merged

ci(renovate): update Node.js Docker rule with semver release notes#684
marcusrbrown merged 1 commit into
mainfrom
plum-outstanding-giraffe

Conversation

@marcusrbrown
Copy link
Copy Markdown
Collaborator

No description provided.

@marcusrbrown marcusrbrown self-assigned this May 28, 2026
@marcusrbrown marcusrbrown requested a review from fro-bot as a code owner May 28, 2026 05:29
@fro-bot fro-bot added the agent: working Agent is currently working on this label May 28, 2026
Copy link
Copy Markdown
Owner

@fro-bot fro-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: CONDITIONAL

The refactor to use sourceUrl for release notes is a clean improvement. One correctness concern with the new regex warrants a fix before merge.

Blocking issues

Regex over-match on matchPackageNames: The new pattern /(?:^|/)node$/ will match any Docker image whose name ends in node — for example alpine/node, custom/node, my-registry.io/team/node, bitnami/node. The old pattern was intentionally narrowed to docker.io/library/node and library/node (i.e. the official Docker Hub library image). If this repo ever pulls in a third-party image whose name ends in /node, Renovate will apply versioning: 'node' and commitMessageTopic: 'Node.js' to it, potentially mis-versioning it. The previous regex was explicit about the namespace; the replacement should be similarly precise.

Suggested fix — keep the intent of matching the official node image only:

matchPackageNames: ['/^(?:(?:docker\.io\/)?library\/)?node$/'],

This matches: node, library/node, docker.io/library/node — exactly the old set, but as a single expression.

Non-blocking concerns

  • Removing commitMessageExtra drops the @{digest} from PR titles. That was intentional per the comment ("includes semver in PR titles"), but worth confirming the resulting title format (chore(build): update dependency Node.js to 24.15.0-alpine) meets expectations.
  • changelogUrl was a direct link to the release tag; sourceUrl points at the repo root and relies on Renovate to resolve release notes. Renovate's GitHub release-note fetching requires a PAT with contents:read on the target repo if it's private — not an issue for nodejs/node (public), but worth noting for the pattern in general.

Missing tests

None — Renovate config changes are not typically unit-tested; the regex can be validated with Renovate's dry-run or the Regex101 tool.

Risk assessment (LOW/MED/HIGH): MED

The regex broadening is the only real risk: unlikely to trigger today (no other /node image in scope), but a latent footgun if the image inventory grows. Everything else is LOW risk.


Run Summary
Field Value
Event pull_request
Repository fro-bot/agent
Run ID 26556624193
Cache hit
Session ses_192eedc90ffe0OH3i7HNq1bXqf

@fro-bot fro-bot removed the agent: working Agent is currently working on this label May 28, 2026
@marcusrbrown
Copy link
Copy Markdown
Collaborator Author

@fro-bot I'm fine with it matching any node

@marcusrbrown marcusrbrown enabled auto-merge (squash) May 28, 2026 05:33
@fro-bot fro-bot added the agent: working Agent is currently working on this label May 28, 2026
Copy link
Copy Markdown
Owner

@fro-bot fro-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood — the broader /(?:^|/)node$/ pattern is intentional and you've accepted the trade-off. The non-blocking items from the prior review (dropped commitMessageExtra / switch from changelogUrl to sourceUrl) are low-risk and the added comment in the config makes the intent clear.

Approving.


Run Summary
Field Value
Event issue_comment
Repository fro-bot/agent
Run ID 26556750798
Cache hit
Session ses_192ec7499ffe1AAg2NfiHYpNkH

@marcusrbrown marcusrbrown merged commit 2ebc8d9 into main May 28, 2026
10 checks passed
@marcusrbrown marcusrbrown deleted the plum-outstanding-giraffe branch May 28, 2026 05:34
@fro-bot fro-bot removed the agent: working Agent is currently working on this label May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants