ci(renovate): remove matchUpdateTypes to fix config error#683
Conversation
fro-bot
left a comment
There was a problem hiding this comment.
Verdict: CONDITIONAL
Blocking issues
Removing matchUpdateTypes: ['digest', 'pinDigest'] broadens this rule to match all update types (major, minor, patch, digest, pinDigest) for the Node.js Docker image. The commitMessageExtra and changelogUrl fields reference {{newDigestShort}}, which is only populated for digest-type updates. For version bumps (major/minor/patch), {{newDigestShort}} will be an empty string, producing:
- Commit messages like
chore(build): update Node.js to 22.0.0@(trailing@with no digest) - Changelog URLs like
.../releases/tag/v22.0.0— this one happens to work, but the template was clearly designed around digest update context
Recommended fix: Retain the commitMessageExtra and changelogUrl overrides only for digest updates, or restructure into two separate rules:
- One matching
['digest', 'pinDigest']with the current digest-specific message templates - One matching version bumps (without the digest-specific templates)
Alternatively, if the intent is to remove the digest-only restriction and consolidate under this rule, the commitMessageExtra and changelogUrl lines should be dropped or made conditional-safe.
Non-blocking concerns
The PR title says "fix config error" — it would be helpful to reference the specific Renovate validation error that prompted this change (e.g. a Renovate config dashboard comment or CI output). Without that context it's hard to verify this is the minimal correct fix.
Missing tests
None applicable — Renovate config changes aren't unit-testable in this repo.
Risk assessment (LOW/MED/HIGH): MED
Low blast radius (only affects Node.js Docker image update PRs), but the broken {{newDigestShort}} interpolation on version-bump PRs will produce cosmetically malformed commit messages until corrected. No security or correctness risk to the application itself.
Run Summary
| Field | Value |
|---|---|
| Event | pull_request |
| Repository | fro-bot/agent |
| Run ID | 26555474759 |
| Cache | hit |
| Session | ses_193106018ffedyPk35YjccMjuA |
|
@fro-bot You came with that last time and Renovate flagged it as invalid config. Approve the PR to fix Renovate |
fro-bot
left a comment
There was a problem hiding this comment.
Approved. You're right — my previous review's recommendation to keep matchUpdateTypes in a split rule was the wrong call. The Renovate docs explicitly warn against combining versioning with matchUpdateTypes in the same rule, since update types aren't known when versioning is applied. That's the root cause of the config error.
Removing matchUpdateTypes is the correct minimal fix. The {{newDigestShort}} cosmetic concern I raised is real but benign — version-bump commits will show a trailing @ with no digest, which is harmless. The config is valid and Renovate will process it correctly.
Run Summary
| Field | Value |
|---|---|
| Event | issue_comment |
| Repository | fro-bot/agent |
| Run ID | 26555645713 |
| Cache | hit |
| Session | ses_1930c5a89ffeUpVNiOjOBU2XJ1 |
No description provided.