Skip to content

2: Fix suppressed df and p-value for overall population #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danielinteractive wants to merge 5 commits into
base: master
Choose a base branch
from
Open

2: Fix suppressed df and p-value for overall population #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
44bdae9
add reprex test
danielinteractive May 5, 2026
9c61257
update pkgdown ... not sure what exactly it is but ok
danielinteractive May 5, 2026
01eb081
make sure that Df has names of the types in CMHtest3
danielinteractive May 5, 2026
0534e76
add another test with multiple types
danielinteractive May 5, 2026
57e8263
added news entry
danielinteractive May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@ Authors@R: c(
email = "d.firth@warwick.ac.uk"),
person(given = "Daniel", family = "Sabanes Bove",
role="ctb",
email = "daniel.sabanesbove@gmail.com"),
email = "daniel@rconis.com",
comment = c(ORCID = "0000-0002-0176-9239")),
person(given = "Matt", family = "Kumar", role="ctb"),
person(given = "Shuguang", family = "Sun", role="ctb"),
person(given = "Gavin", family = "Klorfine", role = "aut")
Expand Down
4 changes: 4 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## Version 0.9.6

* Fixed bug in `CMHtest` which previously suppressed `Df` and `Prob` (p-value) for the overall population results.

## Version 0.9.5

This is a major release of the package, completing work on a sizeable collection of tidy tools
Expand Down
7 changes: 6 additions & 1 deletion R/CMHtest.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,7 +486,12 @@ CMHtest3 <- function(object, types = c("cor", "rmeans", "cmeans", "general")) {
V.list <- lapply(object, function(s) s$V)
A.list <- lapply(object, function(s) s$A)
nt <- sapply(lapply(object, function(s) s$n), sum)
Df <- object[[1]]$table[, "Df"]

tab1 <- object[[1]]$table
Df <- stats::setNames(
tab1[, "Df"],
rownames(tab1)
)

if (length(types) == 1 && types == "ALL") {
types <- c("general", "rmeans", "cmeans", "cor")
Expand Down
Loading
Loading