ISSUE-78: Updates justinrainbow/json-schema to >=6.6 & fixes test #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See \JsonSchema\Entity\ErrorBag::addError, constraint errors are an array and hold all the details inside that key, format top key is gone
Author
|
Tests won't pass bc CI is set for PHP 7.1 (EOL for a while). Should I update CI & composer.json PHP to be more restrictive to PHP 8.1 > too and start targeting only 8.1+ ? |
Author
|
@courtney-miles hi. Could you give this a look? You ok if we drop PHP 7.x ? Thanks a lot |
Coveralls reporting for 8.3
Allow extending classes to access these values, can't find a rational to have these private
PHP 8 supported sin 9.3 Not sure about the <10 here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
See #78
Updates
justinrainbow/json-schemaand fixes test that depends on returned array from the error bag object on validation error (see\JsonSchema\Entity\ErrorBag::addError)Also the phpunit schema was behind, this brings it up to 9.3
Schema Validator
descriptoranderrorproperties moved from private to protected. frictionlessdata/datapackage-php extends that class and needs access to those properties. If a better solution is to access plain accessors (e.g current errors accessor does internal revalidation so not suited for directly accessing already validated data), can do that too.Please preserve this line to notify @courtney-miles (lead of this repository)