fix: inject newline between multipart parts missing trailing newline#1779
Open
jdcc wants to merge 1 commit into
Open
fix: inject newline between multipart parts missing trailing newline#1779jdcc wants to merge 1 commit into
jdcc wants to merge 1 commit into
Conversation
When a multipart CSV file part lacks a trailing newline, its last line was being concatenated directly with the first data line of the next part, corrupting row parsing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a multipart CSV file part lacks a trailing newline, its last line was being concatenated directly with the first data line of the next part, corrupting row parsing.
I don't know if this fix is appropriate for all intended multipart resources, but it works for multipart CSVs.