refactor: Field class independent of Metadata #1751
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierrecamilleri
force-pushed
the
refactor/field-no-metadata
branch
from
6affe37 to
265557f
Compare
pierrecamilleri
force-pushed
the
refactor/field-no-metadata
branch
from
800f7bf to
e88d66f
Compare
Integrated pydantic logic to IntegerField. All tests pass (apart from 5 console ones not related to modifications) Fixed a few issued: - examples should enable Any type, not only strings - descriptor was broken during the merge of two kinds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First attempt to manage the technical debt of the Metedata class.
The aim of this PR is to properly define a descriptor class for the "Field" class, using Pydantic Models.
This descriptor should be immutable.
The first step is to introduce this descriptor for the "BooleanField".
The effort and number of changes this requires testifies of the high coupling the Metadata class has introduced over the whole codebase.