Skip to content

Revert unreleased interface changes #1330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shsms merged 5 commits into from
Dec 16, 2025
Merged

Revert unreleased interface changes #1330

shsms merged 5 commits into from
Dec 16, 2025

Conversation

@shsms
Copy link
Contributor

@shsms shsms commented Dec 16, 2025 •
edited
Loading

These changes were introduced in the PRs #1295 and #1322, and are being reverted here.

@shsms shsms requested a review from a team as a code owner December 16, 2025 12:40
@shsms shsms requested review from florian-wagner-frequenz and removed request for a team December 16, 2025 12:40
@github-actions github-actions bot added part:tests Affects the unit, integration and performance (benchmarks) tests part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) part:data-pipeline Affects the data pipeline part:core Affects the SDK core components (data structures, etc.) part:microgrid Affects the interactions with the microgrid labels Dec 16, 2025
@shsms
Copy link
Contributor Author

shsms commented Dec 16, 2025

Based on #1322

@shsms shsms added the cmd:skip-release-notes It is not necessary to update release notes for this PR label Dec 16, 2025
@shsms
Copy link
Contributor Author

shsms commented Dec 16, 2025

No release notes, because this is reverting unreleased changes.

shsms added 4 commits December 16, 2025 14:29
@shsms
Expose deprecated FormulaEngine and FormulaEngine3Phase types
0cd3135 
Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
@shsms
Make Formulas take a max_size parameter
8173981 
That's what the `FormulaEngine` used to do.

Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
@shsms
Change min/max/coalesce to accept variadic args
ca12ecb 
Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
@shsms
Add ComponentGraph wrapper adding back the component type checks
5e71f34 
That's how it used to be before the rust component graph was
introduced.

Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
Marenz
Marenz previously approved these changes Dec 16, 2025
View reviewed changes
Copy link
Contributor

@Marenz Marenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only complain might be that the last commit also sneaks in dependency updates

@github-project-automation github-project-automation bot moved this from To do to Review approved in Python SDK Roadmap Dec 16, 2025
@shsms
Update release notes
914def4 
Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
@github-actions github-actions bot added the part:docs Affects the documentation label Dec 16, 2025
@shsms
Copy link
Contributor Author

shsms commented Dec 16, 2025

@Marenz the microgrid client is a patch update, and the component graph dep is only being introduced in this release cycle, so we can sneak it in.

Could I get another approval with the release notes?

@llucax
Copy link
Contributor

llucax commented Dec 16, 2025

@Marenz the microgrid client is a patch update, and the component graph dep is only being introduced in this release cycle, so we can sneak it in.

I guess he means they are in an unrelated commit. I agree it would have been nicer to split it into their own commit(s) if they were not related/necessary to the changes in that commit. But just a minor thing, so approving.

@llucax llucax added this to the v1.0.0-rc2300 milestone Dec 16, 2025
@shsms shsms added this pull request to the merge queue Dec 16, 2025
@shsms
Copy link
Contributor Author

shsms commented Dec 16, 2025

I agree it would have been nicer to split it into their own commit(s) if they were not related/necessary to the changes in that commit.

They absolutely are. Graph repo had new subclassability feature needed for that commit. Graph update also includes wind turbines, for which we need client 18.1. So both are related to that commit.

Merged via the queue into frequenz-floss:v1.x.x with commit f539389 Dec 16, 2025
5 checks passed
@shsms shsms deleted the interface-revert branch December 16, 2025 14:18
@github-project-automation github-project-automation bot moved this from Review approved to Done in Python SDK Roadmap Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@llucax llucax llucax approved these changes

@ela-kotulska-frequenz ela-kotulska-frequenz ela-kotulska-frequenz approved these changes

@Marenz Marenz Marenz left review comments

@florian-wagner-frequenz florian-wagner-frequenz Awaiting requested review from florian-wagner-frequenz florian-wagner-frequenz is a code owner automatically assigned from frequenz-floss/python-sdk-team

Assignees

No one assigned

Labels

cmd:skip-release-notes It is not necessary to update release notes for this PR part:core Affects the SDK core components (data structures, etc.) part:data-pipeline Affects the data pipeline part:docs Affects the documentation part:microgrid Affects the interactions with the microgrid part:tests Affects the unit, integration and performance (benchmarks) tests part:tooling Affects the development tooling (CI, deployment, dependency management, etc.)

Projects

Python SDK Roadmap
Status: Done

Milestone

v1.0.0-rc2202

Development

Successfully merging this pull request may close these issues.

4 participants

@shsms @llucax @Marenz @ela-kotulska-frequenz