Make battery power manager algorithm configurable #1323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to expose publicly. Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
With this, `SHIFTING_MATRYOSHKA` remains the default algorithm for batteries, but can now be changed to the original `MATRYOSHKA` algorithm when calling `microgrid.initialize()`. Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
shsms
requested review from
daniel-zullo-frequenz
and removed request for
a team
github-actions
bot
added
part:docs
Contributor
Author
|
This means we need to adjust the docs slightly as well, but will pick that up separately later. |
llucax
approved these changes
Dec 12, 2025
Contributor
llucax
left a comment
llucax
left a comment
There was a problem hiding this comment.
If not too urgent, I would add a power_manager_config: PowerManagerConfig instead from the start, otherwise I'm fine with merge as is for now.
| *, | ||
| api_power_request_timeout: timedelta = timedelta(seconds=5.0), | ||
| # pylint: disable-next: line-too-long | ||
| battery_power_manager_algorithm: PowerManagerAlgorithm = PowerManagerAlgorithm.SHIFTING_MATRYOSHKA, # noqa: E501 |
Contributor
There was a problem hiding this comment.
I guess this is needed somehow soon, but in the future I think it might make more sense to have copy what we have with the resampler_config and add a power_manager_config: PowerManagerConfig, and in there it can have something like power_manager_config.battery.algorithm` for example.
github-project-automation
bot
moved this from To do
to Review approved
in Python SDK Roadmap
cwasicki
approved these changes
Dec 12, 2025
github-project-automation
bot
moved this from Review approved
to Done
in Python SDK Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this,
SHIFTING_MATRYOSHKAremains the default algorithm forbatteries, but can now be changed to the original
MATRYOSHKAalgorithm when calling
microgrid.initialize().