Remove invalid HasField check on proto3 scalar metric value #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scalar fields do not have HasField check in proto3. Signed-off-by: cwasicki <126617870+cwasicki@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the AggregatedMetric.sample() method by removing an invalid HasField("value") check on a proto3 scalar field. In Protocol Buffers version 3, scalar fields (such as numeric types) do not support the HasField() method, which was causing failures when retrieving formula-aggregated metrics.
Key Changes:
- Removed invalid
HasField("value")check from the aggregated metric sample processing logic - Updated release notes to accurately describe the bug fix
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/frequenz/client/reporting/_types.py | Removed invalid proto3 scalar field check (sample.sample.HasField("value")) while keeping the valid message field check (sample.HasField("sample")) |
| RELEASE_NOTES.md | Updated bug fix description to clarify the issue was an invalid HasField check causing failures |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
shsms
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scalar fields do not have HasField check in proto3.