Skip to content

Refactor existing tests #1315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lmagyar wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Refactor existing tests #1315

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions tests/test_tailscale.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ async def test_put_request(aresponses: ResponsesMockServer) -> None:
data={},
)
assert response == '{"status": "ok"}'
await tailscale.close()


async def test_timeout(aresponses: ResponsesMockServer) -> None:
Expand All @@ -91,8 +92,13 @@ async def response_handler(_: aiohttp.ClientResponse) -> Response:
session=session,
request_timeout=1,
)
with pytest.raises(TailscaleConnectionError):
with pytest.raises(TailscaleConnectionError) as excinfo:
assert await tailscale._request("test")
assert (
excinfo.value.args[0]
== "Timeout occurred while connecting to the Tailscale API"
)
await tailscale.close()


async def test_http_error400(aresponses: ResponsesMockServer) -> None:
Expand All @@ -106,8 +112,13 @@ async def test_http_error400(aresponses: ResponsesMockServer) -> None:

async with aiohttp.ClientSession() as session:
tailscale = Tailscale(tailnet="frenck", api_key="abc", session=session)
with pytest.raises(TailscaleError):
with pytest.raises(TailscaleError) as excinfo:
assert await tailscale._request("test")
assert (
excinfo.value.args[0]
== "Error occurred while connecting to the Tailscale API"
)
await tailscale.close()


async def test_http_error401(aresponses: ResponsesMockServer) -> None:
Expand All @@ -121,5 +132,7 @@ async def test_http_error401(aresponses: ResponsesMockServer) -> None:

async with aiohttp.ClientSession() as session:
tailscale = Tailscale(tailnet="frenck", api_key="abc", session=session)
with pytest.raises(TailscaleAuthenticationError):
with pytest.raises(TailscaleAuthenticationError) as excinfo:
assert await tailscale._request("test")
assert excinfo.value.args[0] == "Authentication to the Tailscale API failed"
await tailscale.close()