Skip to content

Add default None values to Optional fields #1267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lmagyar wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add default None values to Optional fields #1267

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
631717f
add default None values to Optional fileds
lmagyar Nov 12, 2025
774ae35
rearrange fields
lmagyar Nov 12, 2025
2c60545
rearrange fields
lmagyar Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 19 additions & 12 deletions src/tailscale/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,15 @@
class ClientSupports(DataClassORJSONMixin):
"""Object holding Tailscale device information."""

hair_pinning: bool | None = field(metadata=field_options(alias="hairPinning"))
ipv6: bool | None
pcp: bool | None
pmp: bool | None
udp: bool | None
upnp: bool | None
hair_pinning: bool | None = field(
default=None,
metadata=field_options(alias="hairPinning"),
)
ipv6: bool | None = None
pcp: bool | None = None
pmp: bool | None = None
udp: bool | None = None
upnp: bool | None = None


@dataclass
Expand All @@ -46,17 +49,11 @@ class Device(DataClassORJSONMixin):
blocks_incoming_connections: bool = field(
metadata=field_options(alias="blocksIncomingConnections")
)
client_connectivity: ClientConnectivity | None = field(
metadata=field_options(alias="clientConnectivity")
)
client_version: str = field(metadata=field_options(alias="clientVersion"))
created: datetime | None
device_id: str = field(metadata=field_options(alias="id"))
expires: datetime | None
hostname: str
is_external: bool = field(metadata=field_options(alias="isExternal"))
key_expiry_disabled: bool = field(metadata=field_options(alias="keyExpiryDisabled"))
last_seen: datetime | None = field(metadata=field_options(alias="lastSeen"))
machine_key: str = field(metadata=field_options(alias="machineKey"))
name: str
node_key: str = field(metadata=field_options(alias="nodeKey"))
Expand All @@ -66,9 +63,19 @@ class Device(DataClassORJSONMixin):
advertised_routes: list[str] = field(
default_factory=list, metadata=field_options(alias="advertisedRoutes")
)
client_connectivity: ClientConnectivity | None = field(
default=None,
metadata=field_options(alias="clientConnectivity"),
)
created: datetime | None = None
enabled_routes: list[str] = field(
default_factory=list, metadata=field_options(alias="enabledRoutes")
)
expires: datetime | None = None
last_seen: datetime | None = field(
default=None,
metadata=field_options(alias="lastSeen"),
)
tags: list[str] = field(default_factory=list)

@classmethod
Expand Down