Add node_id field to Device model #1187
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frenck
requested changes
Aug 28, 2025
Owner
frenck
left a comment
frenck
left a comment
There was a problem hiding this comment.
Oh hi there @edel-macias-cubix 👋
Thanks for the pull request. However, it seems like the CI is failing. Can you please take a look and make it passes?
Thanks 👍
../Frenck
Author
|
Hey! This is ready to merge, could you have a look? 🙏 |
Author
|
Hi! I'd hope this can be merged? |
|
Superseded by #1268, where I add all the missing fileds. I preserved your name/commit, but changed node_id to be not optional. |
Author
|
@lmagyar thanks! And good look having it merged :P |
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
github-actions
bot
added
the
stale
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Added a new field
node_idto the Device model to extend data representation.