Update msbuilder.py #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Variable sn undefined in method: looks like it should be rn_norm.
t[3] to complx[3] in _build_reaction_complex_get2
Update msbuilder.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MSBuilder method _get_template_reaction_complexes has an undefined variable sn that causes an error when I try to run the example code at
https://github.com/freiburgermsu/ModelSEEDpy/blob/f546097837a9f69f2e35c7374264a21836bf6e26/docs/source/model_reconstruction/build_metabolic_model.ipynb
Looks like occurrences of sn should be replaced by rn_norm. Having done that I now have a different error when I attempt to run the code.
I'd appreciate any advice on the modelseedpy package:
Is your fork the most functional (seems much better than the original)?
Is development still active/ongoing?
Do you recommend another package for creating draft metabolic models?
Thanks.