【リファクタリング】現状のソースコードをよりわかりやすい形にメソッド分割を実施 #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
free driveになっていたところをfoofle driveに変更
Alpha9n
requested changes
Oct 29, 2024
src/main/java/ga/ganma/foofledrive/inventoryRelation/InventoryAPI.java
Outdated
Show resolved
Hide resolved
src/main/java/ga/ganma/foofledrive/inventoryRelation/InventoryAPI.java
Outdated
Show resolved
Hide resolved
gobotan
requested review from
Alpha9n and
yui-Kitamura
and removed request for
Alpha9n and
yui-Kitamura
Member
Author
|
レビューを複数人に依頼しようとしたら勝手に外しやがるので一旦猫さんをレビュワーに指定 |
yui-Kitamura
suggested changes
Jan 17, 2025
| <groupId>ga.ganma</groupId> | ||
| <artifactId>foofledrive</artifactId> | ||
| <version>0.7.9β</version> | ||
| <version>1.0.0</version> |
There was a problem hiding this comment.
targetフォルダが上がって来てるけど含まれているjarビルドが旧のまま
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
大まかにリファクタ
動作確認は行っていないが現状コードが分かりづらいためまずは読める状態にする