fix: add support for underscore italic/bold, subscript, and superscript#6
Open
ericclemmons wants to merge 1 commit intofranlol:mainfrom
Open
Conversation
963e75f to
3078e0b
Compare
Add missing markdown stripping patterns for width calculation: - _italic_ and __bold__ (underscore variants) - ___bold+italic___ (underscore variant) - ~subscript~ (single tilde) - ^superscript^ (caret) Also adds bun tests for the new patterns.
3078e0b to
bb8dbd6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds missing markdown stripping patterns for width calculations in concealment mode:
_italic_and__bold__(underscore variants)___bold+italic___(underscore variant)~subscript~(single tilde)^superscript^(caret)Problem
When using markdown like
**_Bold Italic_**orSub~script~, the underscore and single-tilde patterns were not being stripped during width calculation. This caused misaligned table columns because the concealed characters were still being counted toward the display width.Example
Before this fix, a table with these cells would be misaligned:
Changes
Added 5 new regex patterns to
getStringWidth()in the markdown stripping loop: