Skip to content

Changed forward to get mapping #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MatthijsSmets merged 1 commit into from
Sep 25, 2025
Merged

Changed forward to get mapping #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/org/frankframework/application/endpoints/FrontendForwardController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
package org.frankframework.application.endpoints;

import org.springframework.stereotype.Controller;
import org.springframework.web.bind.annotation.GetMapping;
import org.springframework.web.bind.annotation.PathVariable;
import org.springframework.web.bind.annotation.RequestMapping;

@Controller
public class FrontendForwardController {

@RequestMapping(value = "/{path:[^\\.]*}")
@GetMapping(value = "/{path:[^\\.]*}")
Comment on lines +4 to +10
Copy link

Copilot AI Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing from @RequestMapping to @GetMapping creates a breaking change for clients that may be using other HTTP methods (POST, PUT, DELETE) to access this endpoint. Consider if this restriction is intentional, as frontend routing typically needs to handle various HTTP methods for SPA navigation.

Copilot uses AI. Check for mistakes.
public String forward(@PathVariable String path) {
return "forward:/index.html";
}
Expand Down