Updated the dropdown to not be cut-off, added dropdown to forms#226
Open
VincentvanMedenbach wants to merge 9 commits intomasterfrom
Open
Updated the dropdown to not be cut-off, added dropdown to forms#226VincentvanMedenbach wants to merge 9 commits intomasterfrom
VincentvanMedenbach wants to merge 9 commits intomasterfrom
Conversation
Daan0709
requested changes
Feb 12, 2026
Contributor
Daan0709
left a comment
Daan0709
left a comment
There was a problem hiding this comment.
Just some minor changes needed regarding code readability
src/main/frontend/app/components/datamapper/forms/add-conditions-form.tsx
Outdated
Show resolved
Hide resolved
src/main/frontend/app/components/datamapper/forms/add-conditions-form.tsx
Outdated
Show resolved
Hide resolved
src/main/frontend/app/components/datamapper/forms/add-mapping-form.tsx
Outdated
Show resolved
Hide resolved
…ns-form.tsx Co-authored-by: Daan0709 <daanvmaldegem@live.nl> Signed-off-by: VincentvanMedenbach <31502129+VincentvanMedenbach@users.noreply.github.com>
…ns-form.tsx Co-authored-by: Daan0709 <daanvmaldegem@live.nl> Signed-off-by: VincentvanMedenbach <31502129+VincentvanMedenbach@users.noreply.github.com>
…form.tsx Co-authored-by: Daan0709 <daanvmaldegem@live.nl> Signed-off-by: VincentvanMedenbach <31502129+VincentvanMedenbach@users.noreply.github.com>
Co-authored-by: Daan0709 <daanvmaldegem@live.nl> Signed-off-by: VincentvanMedenbach <31502129+VincentvanMedenbach@users.noreply.github.com>
…ns-form.tsx Co-authored-by: Daan0709 <daanvmaldegem@live.nl> Signed-off-by: VincentvanMedenbach <31502129+VincentvanMedenbach@users.noreply.github.com>
…form.tsx Co-authored-by: Daan0709 <daanvmaldegem@live.nl> Signed-off-by: VincentvanMedenbach <31502129+VincentvanMedenbach@users.noreply.github.com>
|
Daan0709
approved these changes
Feb 12, 2026
Matthbo
reviewed
Feb 17, 2026
| className="border-border text-foreground bg-background absolute z-10 mt-1 max-h-60 w-full overflow-auto rounded-md border py-1 shadow-lg" | ||
| className="border-border text-foreground bg-background absolute fixed z-10 mt-1 max-h-60 w-full overflow-auto rounded-md border py-1 shadow-lg" | ||
| style={{ | ||
| top: (dropdownReference.current?.getBoundingClientRect().bottom ?? 0) + window.scrollY, |
Member
There was a problem hiding this comment.
Why is this a fixed position instead of a relative towards the parent?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
Updated dropdown to have fixed styling of the inner list elements, to ensure it can't be cut-off by other elements
After fix:
