Skip to content

Add text filter to PC spellcasting tab#22443

Open
Noisyink wants to merge 1 commit into
foundryvtt:v14-devfrom
Noisyink:spell-tab-text-filter
Open

Add text filter to PC spellcasting tab#22443
Noisyink wants to merge 1 commit into
foundryvtt:v14-devfrom
Noisyink:spell-tab-text-filter

Conversation

@Noisyink
Copy link
Copy Markdown
Contributor

@Noisyink Noisyink commented May 30, 2026

Closes #19937 (text portion; advanced filter to follow).

Added to PC sheets only - Can add to NPC sheets as well if needed but spell lists tend to be smaller on NPCs so figured it wasn't needed.

Test plan

  • PC spellcasting tab: type in the new search input, non-matching spell rows hide, clearing restores

Closes foundryvtt#19937. Test: hard-refresh, open PC spellcasting tab, type in the new search input above the spell-collections panel; rows matching the query by spell name stay visible.
@CarlosFdez
Copy link
Copy Markdown
Collaborator

Screenshot of end result?

@Noisyink
Copy link
Copy Markdown
Contributor Author

Noisyink commented May 30, 2026

Screenshot of end result?

image

Advanced filter is a different PR, so ignore that it's there for this one

@Noisyink
Copy link
Copy Markdown
Contributor Author

Just realised you probably want more than that - I can hide the headers for ranks with no finds if we want? It'd reduce some of the clutter.
image

image

@CarlosFdez
Copy link
Copy Markdown
Collaborator

I'm not sure, people may want to drag/drop it? Maybe if the entry has nothing? I dunno. I'll leave it up to you.

The padding is off though. Its too close to the navigation. Compare with the other tabs. Inventory for example has a 10px top padding.

@Noisyink
Copy link
Copy Markdown
Contributor Author

I'm not sure, people may want to drag/drop it? Maybe if the entry has nothing? I dunno. I'll leave it up to you.

The padding is off though. Its too close to the navigation. Compare with the other tabs. Inventory for example has a 10px top padding.

Might throw a post in the discord, get some feedback. Will mark the padding for fix 🤙

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: text filter for PC spell list

2 participants