Add text filter to PC spellcasting tab#22443
Open
Noisyink wants to merge 1 commit into
Open
Conversation
Closes foundryvtt#19937. Test: hard-refresh, open PC spellcasting tab, type in the new search input above the spell-collections panel; rows matching the query by spell name stay visible.
This was referenced May 30, 2026
Collaborator
|
Screenshot of end result? |
Contributor
Author
Contributor
Author
Collaborator
|
I'm not sure, people may want to drag/drop it? Maybe if the entry has nothing? I dunno. I'll leave it up to you. The padding is off though. Its too close to the navigation. Compare with the other tabs. Inventory for example has a 10px top padding. |
Contributor
Author
Might throw a post in the discord, get some feedback. Will mark the padding for fix 🤙 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Closes #19937 (text portion; advanced filter to follow).
Added to PC sheets only - Can add to NPC sheets as well if needed but spell lists tend to be smaller on NPCs so figured it wasn't needed.
Test plan