Localize family ability glossary#22386
Open
iDantar wants to merge 2 commits into
Open
Conversation
TikaelSol
reviewed
May 31, 2026
Comment on lines
+1
to
+10
| /** | ||
| * Apply bestiary-family-ability-glossary name localization for local testing. | ||
| * | ||
| * - Prepends an ItemAlteration rule that overrides each ability's display name | ||
| * - Adds PF2E.NPCAbility.<Family>.<Ability>.Name entries to static/lang/re-en.json | ||
| * - Ability keys use the pack name after the parenthetical prefix | ||
| * (e.g. "(Vampire, Jiang-Shi, Minister) Dark Enlightenment" → DarkEnlightenment) | ||
| * | ||
| * Usage: node scripts/localize-family-glossary.mjs [--dry-run] | ||
| */ |
Collaborator
Author
There was a problem hiding this comment.
Thought this could be helpful for the review - not planning to include it in the final merge
Collaborator
Author
There was a problem hiding this comment.
Removed it - it's still available in commit history, if needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an ItemAlteration for name on each of the abilities in
packs\pf2e\bestiary-family-ability-glossary, to replace it with a localized one, without parenthesis mentioning the family name. So(Vampire, Jiang-Shi, Basic) One More Breathbecomes justOne More BreathTo a kind reviewer: updates were done via script (included in PR for now, for convenience), so please don't be discouraged by change's size :)
One change post-script that I did was to Skymetal Metamorphosis abilities, as those already had entries in re-en
Kudos to @pedrogrullada for the idea