Skip to content

Apply materials from base damage to splash damage roll#22369

Open
iDantar wants to merge 1 commit into
foundryvtt:v14-devfrom
iDantar:19669-apply-materials-to-splash-damage
Open

Apply materials from base damage to splash damage roll#22369
iDantar wants to merge 1 commit into
foundryvtt:v14-devfrom
iDantar:19669-apply-materials-to-splash-damage

Conversation

@iDantar
Copy link
Copy Markdown
Collaborator

@iDantar iDantar commented May 19, 2026

@stwlam
Copy link
Copy Markdown
Collaborator

stwlam commented May 20, 2026

Materials can't be used as damage flavor tags. except for the fact that I added it myself 🫠

@iDantar
Copy link
Copy Markdown
Collaborator Author

iDantar commented May 20, 2026

Sorry, I'm not sure I follow what's meant by "can't be used" in this context.
If it's "this wouldn't work" - at least from my testing it looks to work
image
If you meant more like "this shouldn't be used because of unwanted side-effects" - could you please share more details on what this could affect?

@CarlosFdez
Copy link
Copy Markdown
Collaborator

CarlosFdez commented May 29, 2026

The only thing that brings me pause here is that we inject a lot of material options using stuff like damage:material:silver into roll options of inline damage. So there is a mismatch of expectations somewhere. I think this one is up to stwlam to resolve. So long as its possible I'm not fussy with the how.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Splash damage should inherit special material traits from originating weapon

3 participants