Brush up persistent damage chat card#22368
Conversation
|
|
||
| /* Borders */ | ||
| --color-border-divider: #baa991; | ||
| --color-underline-header: #782e22; |
There was a problem hiding this comment.
@stwlam override me here due to familiarity but this looks like an appv1 color, which I think we aren't supposed to reinstate. Might be good to find an appv2 equivalent (or remove the underline, I don't think we need it).
There was a problem hiding this comment.
Chiming in as I've done a lot of core css var digging recently. It is an appv1 color, used as the default border under h1/h2/h3. Appv2 doesn't automatically underline headings anymore and doesn't have a direct equivalent.
There was a problem hiding this comment.
Personally, I like it a bit more with the line, especially if there are multiple instances of persistent, but I'm by no means a UI person
I removed the --color-underline-header and used --color-scrollbar for now, plus replaced that color's usage in all other places
There was a problem hiding this comment.
Without it is. Also rolled back other color changes, to avoid unnecessary side-effects
4 participants
Looks like this after update:
