Add back TakesNoDamage text on applyDamage card#22366
Conversation
iDantar
commented
May 19, 2026
iDantar
commented
- Closes Damage message for immunities in chat is coming up empty #22364
| return hitPoints.value === hitPoints.max ? `${locPrefix}.AtFullHealth` : `${locPrefix}.HealedForN`; | ||
| } | ||
| if (!hitPoints.max || finalDamage - damageAbsorbedByActor === 0) { | ||
| return persistentCreated ? null : `${locPrefix}.TakesNoDamage`; |
There was a problem hiding this comment.
this looks like the intent is to not show the "takes no damage" message if persistent damage was created. But persistentCreated is always truthy. This should clearly be persistentCreated.length instead of outright removal.
There was a problem hiding this comment.
I tried that, but imo it didn't look good
Maybe if we also move the undo button lower, into Persistent Damage block?
There was a problem hiding this comment.
Have it use the natural language that would otherwise be there ("Leng Spider starts taking 1d4 persistent damage.").
There was a problem hiding this comment.
Sorry, not sure if I got you right - something like this?
There was a problem hiding this comment.
Almost, but no big heading or bulleted list
"Leng Spider starts taking 1d4 bleed and 1d4 persistent acid damage."
There was a problem hiding this comment.
Pushed the changes, looks like this now:
There was a problem hiding this comment.
Avoid the : and use whatever rendering the inline damage cards do.
@Damage[{4[persistent,fire],5[persistent,cold]}] turns into 4 persistent fire + 5 persistent cold
There was a problem hiding this comment.
Just to make sure: this is a message about damage received - they usually don't render the inline damage rolls. Could you confirm that they are needed here, please?
There was a problem hiding this comment.
I removed the colon, but please confirm about the inline damage rendering @CarlosFdez - are you sure we need to add it here?
3 participants
