Add rules for verdant- and pristine- weapon feats#22362
Conversation
I used icon's prompt as a base, but I like your suggestion more, thanks! Co-authored-by: TikaelSol <80183198+TikaelSol@users.noreply.github.com>
| "adjustName": false, | ||
| "choices": [ | ||
| { | ||
| "label": "PF2E.SpecificRule.Exemplar.Ikon.Physical.Grant", |
There was a problem hiding this comment.
Maybe make it a generic label since it's not limited to Exemplar anymore? And the other choice too.
There was a problem hiding this comment.
I think it's a good idea, but wouldn't we need a migration for that then?
There was a problem hiding this comment.
I guess it's either that or making a duplicate, and creating a migration just to replace 1 string seems wasteful. Oh well, might well leave as is and migrate some other time together with other language keys replacement.
|
Thought a bit more about it and moved to more general localization keys - you both were right |
| "EquipmentVariety": "Select an item variety.", | ||
| "Existing": "Use an existing item in my inventory.", | ||
| "EvolutionFeat": "Select a first evolution feat.", | ||
| "Feat": "Select a feat.", | ||
| "Feature": "Select a feature.", | ||
| "FirstImplement": "Select a first implement.", | ||
| "Form": "Select a form.", | ||
| "Grant": "Grant me a new item.", | ||
| "Heritage": "Select a heritage.", |
There was a problem hiding this comment.
These wouldn't go in here, as they aren't prompt text.
There was a problem hiding this comment.
Good call, moved them to PF2E.UI.RuleElements.GrantItem - feels appropriate to me, what would you say?
Co-authored-by: TikaelSol <80183198+TikaelSol@users.noreply.github.com>
3 participants
P.S. not entirely sure about weapon groups predicates on Verdant Weapon - would appreciate the suggestions