[#4060] Add teleport activity#6904
Open
Kapuzenjoe wants to merge 8 commits into
Open
Conversation
arbron
requested changes
Apr 6, 2026
arbron
requested changes
Apr 6, 2026
Fyorl
added
strategic
arbron
requested changes
May 13, 2026
Co-authored-by: Jeff Hitchcock <github444@command-center.org>
Co-authored-by: Jeff Hitchcock <github444@command-center.org>
Kapuzenjoe
force-pushed
the
4060-teleport-activity
branch
from
08f8c20 to
d6d7a34
Compare
arbron
approved these changes
Jun 3, 2026
Collaborator
arbron
left a comment
arbron
left a comment
There was a problem hiding this comment.
Just a bit of clean up for the sheet but otherwise its looking good to me.
A few thoughts for future improvement to make things clearer when planning the teleport:
- Display icon underneath or outline around token to be teleported
- Add some way to cancel planned movement
- Add UI to indicate movement being planned like discussed in #6796 for placements
Comment on lines
+29
to
+36
| /** @inheritDoc */ | ||
| async _prepareEffectContext(context, options) { | ||
| context = await super._prepareEffectContext(context, options); | ||
| return context; | ||
| } | ||
|
|
||
| /* -------------------------------------------- */ | ||
|
|
Collaborator
There was a problem hiding this comment.
Suggested change
| /** @inheritDoc */ | |
| async _prepareEffectContext(context, options) { | |
| context = await super._prepareEffectContext(context, options); | |
| return context; | |
| } | |
| /* -------------------------------------------- */ |
| effect: { | ||
| template: "systems/dnd5e/templates/activity/teleport-effect.hbs", | ||
| templates: [ | ||
| ...super.PARTS.effect.templates, |
Collaborator
There was a problem hiding this comment.
Not including an active effects on this tab, so the other templates aren't necessary.
Suggested change
| ...super.PARTS.effect.templates, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I used the opportunity to turn the new Foundry API from foundryvtt/foundryvtt#13935, specifically
token.planMovement, into a dedicated activity type for #4060Functionally, activating the activity lets the user drag the token to the desired destination. After the move is completed, the token returns to its default movement mode.
example_teleport.mov
Feel free to rate the implementation. I tried to stick as closely as possible to the standard system.