Skip to content

Conversation

@abdollahShahid
Copy link
Contributor

@abdollahShahid abdollahShahid commented Jan 2, 2026

Summary

  • Add missing GitHub Actions workflow permissions required for python-semantic-release (issues, pull-requests).
  • Improve concurrency configuration to prevent overlapping release runs.

Test plan

  • CI checks pass on GitHub Actions
  • Verified only .github/workflows/semantic-release.yml was modified
  • YAML validated locally (syntax only)

Related to #143

Copilot AI review requested due to automatic review settings January 2, 2026 11:25
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the semantic-release workflow configuration to ensure proper permissions and prevent concurrent release operations. The changes address missing GitHub Actions permissions required for python-semantic-release to fully manage releases and improve the concurrency settings to prevent race conditions.

  • Expanded workflow permissions to include issues and pull-requests write access
  • Restructured concurrency configuration with explicit group naming and cancel-in-progress: false to prevent overlapping releases
  • Minor code cleanup including comment removal and trailing whitespace fixes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@abdollahShahid
Copy link
Contributor Author

abdollahShahid commented Jan 2, 2026

Hi maintainers
This PR fixes missing permissions required by python-semantic-release and improves concurrency to prevent overlapping release runs.
Happy to adjust if you prefer different permission scope or concurrency naming.

@deveaud-m
Copy link
Collaborator

@abdollahShahid thanks for creating this PR and trying to improve the semantic release workflow.

I activated the actions for this PR, the failed tests are not related to this change, it is fine to merge without the full functional testsuite.

I added some minor nitpick suggestions to improve the comments, I am not a fan of emojis in code files, I hope that's fine for you to delete them.

The PR will be ready to merge once the suggestions are accepted, but this won't fully fix issue #143. Could you please adapt the description to avoid closing the issue after the merge?

@deveaud-m deveaud-m assigned abdollahShahid and unassigned deveaud-m Jan 2, 2026
@abdollahShahid
Copy link
Contributor Author

Thanks for the review! I’ve removed the emojis from the workflow comments and updated the PR description so it no longer closes #143. Ready for merge.

Copy link
Collaborator

@deveaud-m deveaud-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like I forgot to send the pending reviews...

@abdollahShahid
Copy link
Contributor Author

@deveaud-m No worries at all — thanks for the confirmation. Ready to merge whenever convenient.

@deveaud-m
Copy link
Collaborator

@abdollahShahid sorry for the delay, I was on holidays. Please integrate the last change as suggested before I can merge.

@deveaud-m
Copy link
Collaborator

@deveaud-m No worries at all — thanks for the confirmation. Ready to merge whenever convenient.

I just merged a fix for the failing tests. Could you please update your fork and insert the second suggestion? I'll re-run the workflow and continue working on new features and fixes.

@abdollahShahid abdollahShahid force-pushed the fix/verify-semantic-release branch from 9112887 to 67c7db4 Compare January 8, 2026 21:17
@abdollahShahid
Copy link
Contributor Author

Hi @deveaud-m — sorry for the delay, I’ve been busy contributing to a core repository recently.

I’ve now updated my fork, rebased onto the latest main, and applied the remaining suggestion (removed the redundant workflow comment). Thanks a lot for the review and guidance!

Whenever you have time, could you kindly take a look at PR #157 as well?

Thanks again!

@deveaud-m deveaud-m merged commit c43a606 into fossology:main Jan 8, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants