Add license extraction for pyproject.toml#270
Conversation
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds Changespyproject.toml License Extraction
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/fosslight_source/run_manifest_extractor.py`:
- Around line 128-156: The get_licenses_from_pyproject_toml function falls back
to importing tomli for Python <3.11 but tomli is missing from dependencies; add
tomli to the project's pyproject.toml dependencies (e.g., add a conditional
dependency "tomli>=1.0.0; python_version < '3.11'") so the fallback import in
get_licenses_from_pyproject_toml works on Python 3.10 and similar runtimes.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: fd9017c8-eb3c-486d-82cb-5fb2be70bddd
📒 Files selected for processing (2)
src/fosslight_source/_scan_item.pysrc/fosslight_source/run_manifest_extractor.py
Signed-off-by: Wonjae Park <j.wonjae.park@gmail.com>
2503149 to
3d46a81
Compare
|
|
@JustinWonjaePark , license에는 SPDX 포맷이 아닌 경우도 입력될 수 있습니다. |
반영했습니다.
|
Signed-off-by: Wonjae Park <j.wonjae.park@gmail.com>
8aa6aee to
18e9054
Compare
New Features
pyproject.tomlas a manifest filepyproject.tomlconfigurations, supporting both structured and text-based license declarations