Skip to content

Conversation

@Trimitor
Copy link
Contributor

@Trimitor Trimitor commented Nov 12, 2025

@pangolp
Copy link
Member

pangolp commented Nov 13, 2025

I made a few small changes to reduce the number of SQL queries executed. While I may eventually migrate all the information from the different files to the database, until then, we'll try to minimize the number of queries run. This can be achieved, for example, by grouping all the INSERT INTO statements and checking for DELETE FROM statements that share common fields.

@pangolp
Copy link
Member

pangolp commented Nov 13, 2025

I believe the two crossed-out missions could have an objective within the dungeon, since the NPC we need to find is inside it. Also, perhaps it's my mistake, but I don't have areas, only points. However, I'll try running the first SQL query because perhaps I made a mistake while trying to optimize it, which is why my result is different. And point 2 should perhaps be placed a little further in, within the area the player can walk through.

To continue from where I left off, you can update the branch, downloading the changes I made. This way you can continue generating commits after the ones I just added. In any case, I'll test the original queries, just in case I made a mistake while trying to reduce them.

@pangolp
Copy link
Member

pangolp commented Nov 13, 2025

To help you understand the difference between what I did and what you did (which isn't critical), I've gone from 20 inquiries to 8 by grouping them. But in doing so, I may have made a mistake.

  • Before: 20 queries executed, 20 success, 0 errors, 0 warnings
  • After: 8 queries executed, 8 success, 0 errors, 0 warnings

But it's no use, and you don't get the same result.

@pangolp
Copy link
Member

pangolp commented Nov 13, 2025

I just reviewed the original query, and indeed, I made a mistake in optimizing it, so I'm going to review it in a little more detail.

@pangolp
Copy link
Member

pangolp commented Nov 13, 2025

I think the objectives of this quest are incorrect, and although it's not inside the dungeon, it takes place within it. https://www.wowhead.com/wotlk/quest=5722/searching-for-the-lost-satchel. Therefore, it's fine that quest 5724 isn't included, because it's a continuation of another quest. Completing that quest sends us out of the dungeon. But the objective of quest 5722 should be to mark the body of the NPC inside the dungeon.

@pangolp
Copy link
Member

pangolp commented Nov 13, 2025

Some very small changes could be made to quest number 2, but I don't know if it is really worth it, because it would be moving it a little more to the center, but it is a detail that can really be corrected at another time. And regarding the order of one of the quests, perhaps it could also be changed, which should be the priority perhaps, or the order in which the enemies are added to the list, which is the mission: https://www.wowhead.com/wotlk/quest=5728/hidden-enemies. Since there is an enemy, who is first than the other, within the map, but it is a detail, which I don't know if it is really worth correcting at this moment.

@Trimitor
Copy link
Contributor Author

Yes, I understand what you mean. The main point is that the data is auto-generated. But in this case, I will manually group the data before committing. I used your file as a basis.

@Trimitor
Copy link
Contributor Author

As for https://www.wowhead.com/wotlk/quest=5722/searching-for-the-lost-satchel, you're right, that's my mistake.

@pangolp
Copy link
Member

pangolp commented Nov 13, 2025

As for https://www.wowhead.com/wotlk/quest=5722/searching-for-the-lost-satchel, you're right, that's my mistake.

No problem, I actually wanted to add the 5724 actually, and then, I realized it was the Quest 5722 that I had to work with.

@pangolp
Copy link
Member

pangolp commented Nov 13, 2025

Yes, I understand what you mean. The main point is that the data is auto-generated. But in this case, I will manually group the data before committing. I used your file as a basis.

Both serve (grouped or self-generated). Because it can always be improved in the future. The important thing is to add the dots, to complement the use of the maps. Although the maps are on the client and these points are on the server, so it is up to the administrator to add them or not.

@pangolp pangolp merged commit 2ada563 into forumcorex:master Nov 22, 2025
1 check passed
pangolp added a commit that referenced this pull request Nov 22, 2025
* Chore. Quests in The Deadmines #5

Added missing POIs for quests in The Deadmines:
 - [ ] ~~[Collecting Memories - Quest - WotLK Classic](https://www.wowhead.com/wotlk/quest=168/collecting-memories)~~ No need to add POI
 - [x] [The Defias Brotherhood - Quest - WotLK Classic](https://www.wowhead.com/wotlk/quest=166/the-defias-brotherhood)
 - [ ] ~~[Oh Brother. . . - Quest - WotLK Classic](https://www.wowhead.com/wotlk/quest=167/oh-brother)~~ No need to add POI
 - [x] [Underground Assault - Quest - WotLK Classic](https://www.wowhead.com/wotlk/quest=2040/underground-assault)
 - [x] [Red Silk Bandanas - Quest - WotLK Classic](https://www.wowhead.com/wotlk/quest=214/red-silk-bandanas) The quest can be completed both inside and outside the dungeon
 ---
 - [ ] ~~[The Unsent Letter - Quest - Classic World of Warcraft](https://www.wowhead.com/classic/quest=373/the-unsent-letter)~~ No need to add POI

**Gallery**
https://imgur.com/a/OZwS0Qn

* Query optimization

* Blank new line

* Quests in Ragefire Chasm (#7)

* Chore. Quests in Ragefire Chasm #4

Added missing POIs for quests in Ragefire Chasm:
 - [x] https://www.wowhead.com/wotlk/quest=5728/hidden-enemies
 - [x] https://www.wowhead.com/wotlk/quest=14356/the-power-to-destroy
 - [x] https://www.wowhead.com/wotlk/quest=5723/testing-an-enemys-strength
 - [x] https://www.wowhead.com/wotlk/quest=5761/slaying-the-beast
 - [ ] ~~https://www.wowhead.com/wotlk/quest=5724/returning-the-lost-satchel~~ No need to add POI
 - [ ] ~~https://www.wowhead.com/wotlk/quest=5722/searching-for-the-lost-satchel~~ No need to add POI

**Gallery**
https://imgur.com/a/RGG8OfS

* Minor corrections to queries

* Grouping queries to reduce the amount

* add quest 5722

* All missions tested and fixed

---------

Co-authored-by: Pagani Walter <paganiwalter@gmail.com>

* All missions tested and fixed

---------

Co-authored-by: Pagani Walter <paganiwalter@gmail.com>
@Trimitor Trimitor deleted the Ragefire-Chasm branch November 29, 2025 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Classic Ragefire Chasm Quests

2 participants