fix: defer process wait context cleanup #166
Conversation
Avoid freeing process wait contexts while their completions are still active; clean them up in the exit callback instead.
There was a problem hiding this comment.
Pull request overview
This PR fixes a use-after-free bug where process wait contexts were being freed prematurely while their completions were still active. The fix defers cleanup to the exit callback after the completion has been properly disarmed.
Changes:
- Removed premature
process_wait_ctxdestruction from initialization and cleanup paths - Added context cleanup logic in the exit callback after verifying completions are disarmed
- Updated documentation with troubleshooting entry about crashes after terminal close events
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/session/state.zig | Deferred process wait context cleanup to exit callback to prevent use-after-free |
| README.md | Added troubleshooting entry for crash after terminal close events |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a5a6a55917
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Addresses review comments 2721769248, 2721774894.
Avoid freeing process wait contexts while their completions are still active; clean them up in the exit callback instead.