handle Cmd+W window close requests #164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: App crashed on macOS when closing a terminal with Cmd+W (see crash report) and needs safe close handling. Solution: handle SDL window close/destroy events and suppress Cmd+W-triggered close requests on macOS to avoid tearing down the window. Solution: exit the main loop immediately after quit and document Cmd+W vs quit behavior.
There was a problem hiding this comment.
Pull request overview
This PR handles window close requests on macOS to prevent Cmd+W from closing the application window while allowing proper quit behavior through Cmd+Q or the window close button.
Changes:
- Added SDL window close event handling with macOS-specific suppression of Cmd+W-triggered close requests
- Updated main loop to exit immediately after quit is requested
- Clarified the distinction between Cmd+W (terminal close) and Cmd+Q/window close button (application quit) in documentation
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/c.zig | Exported SDL window close and destroy event constants |
| src/app/runtime.zig | Implemented Cmd+W suppression logic and window close event handlers |
| docs/configuration.md | Updated documentation to clarify Cmd+W vs quit behavior |
| README.md | Updated keyboard navigation description to distinguish terminal close from application quit |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Addresses review comments 2720612556, 2720612576, 2720612588.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: