fix: improve grid navigation wraparound and notification UX #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: Cmd+left from the leftmost cell wrapped to the last grid cell even if empty; pressing Enter didn't clear notification highlighting; and the notification tint overlay was barely visible. Solution: Updated grid navigation to find the rightmost spawned terminal when wrapping left. Added attention clearing when any key is forwarded to the terminal in Grid mode (not just text input). Increased notification tint alpha from 25 to 55 for better visibility.
There was a problem hiding this comment.
Pull request overview
This PR improves grid navigation behavior and notification user experience by fixing wraparound logic and enhancing visual feedback.
Changes:
- Fixed Cmd+left grid navigation to land on the rightmost spawned terminal instead of potentially empty cells
- Extended notification clearing to trigger on any key press, not just text input events
- Increased notification tint opacity for better visibility
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/app/grid_nav.zig | Adds logic to find rightmost spawned terminal when wrapping left from column 0 |
| src/app/runtime.zig | Clears notification attention on any key press in Grid mode |
| src/render/renderer.zig | Increases notification overlay alpha from 25/35 to 55 for better visibility |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Solution
Grid navigation wraparound (
src/app/grid_nav.zig): When pressing Cmd+left from the leftmost column (column 0), the navigation now searches backward from the last column to find the rightmost spawned terminal, rather than unconditionally landing on the last cell which might be empty.Notification clearing on key press (
src/app/runtime.zig): Previously, onlySDL_EVENT_TEXT_INPUTevents cleared the notification attention flag. Keys like Enter, Tab, and arrow keys only generateSDL_EVENT_KEY_DOWNevents (no TEXT_INPUT), so they didn't clear the highlighting. Now any key forwarded to the terminal in Grid mode clears the attention.Notification tint visibility (
src/render/renderer.zig): Increased the alpha value of the notification overlay tint from 25/35 to 55, making the yellow (awaiting approval / running) and green (done) highlights more visible while still being subtle enough not to obscure terminal content.