NEW @W-20773626@ ESLint rules for react typescript static analysis

.vscode/launch.json

@@ -27,6 +27,48 @@
         "NODE_OPTIONS": "--experimental-vm-modules"
       },
       "console": "integratedTerminal"
+    },
+    {
+      "type": "node",
+      "request": "launch",
+      "name": "Debug engine.test.ts (single test)",
+      "cwd": "${workspaceFolder}",
+      "program": "${workspaceFolder}/node_modules/.bin/jest",
+      "args": [
+        "packages/code-analyzer-eslint-engine/test/engine.test.ts",
+        "-t",
+        "When file_extensions is only .tsx, then only react rules are returned",
+        "--runInBand",
+        "--coverage=false"
+      ],
+      "env": {
+        "NODE_OPTIONS": "--experimental-vm-modules"
+      },
+      "console": "integratedTerminal",
+      "internalConsoleOptions": "neverOpen",
+      "skipFiles": [
+        "<node_internals>/**"
+      ]
+    },
+    {
+      "type": "node",
+      "request": "launch",
+      "name": "Debug Jest (watch all)",
+      "cwd": "${workspaceFolder}",
+      "program": "${workspaceFolder}/node_modules/.bin/jest",
+      "args": [
+        "--runInBand",
+        "--coverage=false",
+        "--watch"
+      ],
+      "env": {
+        "NODE_OPTIONS": "--experimental-vm-modules"
+      },
+      "console": "integratedTerminal",
+      "internalConsoleOptions": "neverOpen",
+      "skipFiles": [
+        "<node_internals>/**"
+      ]
     }
   ]
 }

packages/code-analyzer-eslint-engine/src/base-config.ts

@@ -199,10 +199,13 @@ export class BaseConfigFactory {
      * Note: TypeScript React support (.tsx) is planned for the next iteration.
      */
     private createReactConfigArray(): Linter.Config[] {
-        // Apply React rules to all JavaScript files
+        // Apply React rules to all JavaScript and TypeScript files
+
         const jsExtensions = this.engineConfig.file_extensions.javascript;
+        const tsExtensions = this.engineConfig.file_extensions.typescript;
+        const reactExtensions = [...new Set([...jsExtensions, ...tsExtensions])];
 
-        if (jsExtensions.length === 0) {
+        if (reactExtensions.length === 0) {
             return [];
         }
 
@@ -211,7 +214,7 @@ export class BaseConfigFactory {
 
         return [{
             ...reactAllConfig,
-            files: jsExtensions.map(ext => `**/*${ext}`),
+            files: reactExtensions.map(ext => `**/*${ext}`),
             settings: {
                 ...reactAllConfig.settings,
                 react: {
@@ -246,9 +249,10 @@ export class BaseConfigFactory {
 
     private useReactBaseConfig(): boolean {
         // React config is independently controlled by disable_react_base_config
-        // React rules apply to all JS files - no harm if file has no React code
+        // React rules apply to all JS and TS files - no harm if file has no React code
         return !this.engineConfig.disable_react_base_config && 
-               this.engineConfig.file_extensions.javascript.length > 0;
+               (this.engineConfig.file_extensions.javascript.length > 0 ||
+                this.engineConfig.file_extensions.typescript.length > 0);
     }
 }
 

packages/code-analyzer-eslint-engine/src/config.ts

@@ -73,7 +73,7 @@ export const DEFAULT_CONFIG: ESLintEngineConfig = {
     disable_react_base_config: true,  // Gated for now - will change to false when released
     file_extensions: {
         javascript: ['.js', '.cjs', '.mjs', '.jsx'],
-        typescript: ['.ts'],  // Note: .tsx support planned for next iteration
+        typescript: ['.ts', '.tsx'],
         html: ['.html', '.htm', '.cmp'],
         css: ['.css', '.scss'],
         other: []

packages/code-analyzer-eslint-engine/src/rule-mappings/constants.ts

@@ -0,0 +1,4 @@
+// Convenience tag to apply to framework specific rules
+export const LWC = "LWC";
+export const SLDS = "SLDS";
+export const REACT = "React";