Add UI tests for refresh token rotation#2888
Open
wmathurin wants to merge 2 commits into
Open
Conversation
- Add ECA_OPAQUE_RTR and ECA_JWT_RTR to KnownAppConfig enum in UITestConfig - Add AppConfig.isRtr property (mirrors issuesJwt pattern) - Add assertRevokeAndRefreshWorks(isRtr) to AuthFlowTest base class: asserts refresh token rotates for RTR apps and stays stable for non-RTR apps - Add RTRLoginTests: 4 non-restart tests covering hybrid/no-hybrid × jwt/opaque RTR apps - Update ui_test_config.json.sample with eca_jwt_rtr and eca_opaque_rtr entries - Update README.md with RTRLoginTests section and updated app config list
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #2888 +/- ##
============================================
- Coverage 55.13% 55.11% -0.02%
- Complexity 2495 2505 +10
============================================
Files 226 226
Lines 17722 17781 +59
Branches 2311 2328 +17
============================================
+ Hits 9771 9800 +29
- Misses 6955 6974 +19
- Partials 996 1007 +11
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Known failures — W-22512846
`testECAJwtRtr_Hybrid` is expected to fail until W-22512846 (Enable Named JWTs for Hybrid Flows) is resolved on the server side.
The server currently returns `invalid_grant` when RTR is used with JWT-based access tokens in hybrid flow. The three remaining tests (opaque hybrid, jwt no-hybrid, opaque no-hybrid) are expected to pass.
Notes
This is the Android equivalent of iOS PR #4035. The restart variants (`_WithRestart`) are omitted — Android does not currently have an equivalent of iOS's `restartAndValidateUser` infrastructure.