Skip to content

UIDEXP-423 Display spinner and edited data when open Job profile view form after edit#578

Merged
vashjs merged 3 commits intomasterfrom
UIDEXP-423
Mar 24, 2026
Merged

UIDEXP-423 Display spinner and edited data when open Job profile view form after edit#578
vashjs merged 3 commits intomasterfrom
UIDEXP-423

Conversation

@vashjs
Copy link
Contributor

@vashjs vashjs commented Mar 22, 2026

After editing a data export job profile, when opening the view form, the old data was briefly displayed before changing to the edited data. This creates a confusing user experience. This PR reworks the approach to display a spinner during data refresh and then show the new version with edited data.

Changes:

  • Extracted isFetching state from both useQuery hooks (isJobProfileFetching and isMappingProfileFetching)
  • Updated isLoading calculation to include the fetching states: isLoading = isJobProfileFetching || isMappingProfileFetching || !jobProfileRecord || !mappingProfileRecord

Refs: UIDEXP-423

@github-actions
Copy link

Jest Unit Test Results

  1 files  ±0   43 suites  ±0   3m 41s ⏱️ -1s
361 tests  - 1  342 ✅  - 1  19 💤 ±0  0 ❌ ±0 
362 runs   - 1  343 ✅  - 1  19 💤 ±0  0 ❌ ±0 

Results for commit 6ad8763. ± Comparison against base commit 49f4adf.

This pull request removes 1 test.
JobProfileDetails rendering details for non default job profile without job execution data should display job profile details for non default job profile ‑ JobProfileDetails rendering details for non default job profile without job execution data should display job profile details for non default job profile

@sonarqubecloud
Copy link

@vashjs vashjs requested a review from a team March 22, 2026 23:45
@vashjs vashjs marked this pull request as ready for review March 22, 2026 23:45
@Dmytro-Melnyshyn Dmytro-Melnyshyn requested a review from a team March 24, 2026 07:22
@vashjs vashjs merged commit aa2647d into master Mar 24, 2026
15 checks passed
@vashjs vashjs deleted the UIDEXP-423 branch March 24, 2026 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants