Skip to content

MODDATAIMP-1234 - Upgrade module to Vert.x 5.0#380

Merged
RuslanLavrov merged 12 commits intomasterfrom
MODDATAIMP-1234
Mar 27, 2026
Merged

MODDATAIMP-1234 - Upgrade module to Vert.x 5.0#380
RuslanLavrov merged 12 commits intomasterfrom
MODDATAIMP-1234

Conversation

@RuslanLavrov
Copy link
Copy Markdown
Contributor

@RuslanLavrov RuslanLavrov commented Mar 14, 2026

Purpose

upgrade the module to Vertx 5

Approach

  • MODULE_SPECIFIC_ARGS no longer exists so "file.processing.buffer.record.charset" has been exposed as module property
  • FileSystem.deleteRecursive(String path, boolean recursive) method has been deprecated and replaced with FileSystem.deleteRecursive(String path) in Vertx 5
  • FileSplitWriter was refactored since WriteStream.write(Buffer data, Handler<AsyncResult> handler) method has been deprecated and replaced with WriteStream.write(Buffer data) in Vertx 5
  • testDownloadPresignedKeyNotPresentWithSimilarFiles() and testDownloadPresignedKeyNotPresentWithNoMatch() tests have been updated because now after refactoring MinioStorageServiceImpl::getFileDownloadUrl method the client.getPresignedUrl() is no longer called if the key/file is not found in the S3 bucket (as there is no need to call client.getPresignedUrl() in this case)
  • vertxContext.executeBlocking() method has been deleted from the FileSplitWriter::uploadChunkAsync() method, because
    the minioStorageService.write method already executes logic in vertxContext.executeBlocking()
  • fixed FileSplitWriterExceptionalTest::testInvalidDirectory() test - the FileSplitWriter::end() method has been updated with the check before failing chunkUploadingCompositeFuturePromise to prevent failing it twice, if specified chunkFolder does not exist
  • the ensureProcessFilesRqDtoWithFileDefinitionSourcePath() method has been added to the POST /data-import/uploadDefinitions/{uploadDefinitionId}/processFiles endpoint logic to ensure that the ProcessFilesRqDto request contains the FileDefinition.sourcePath field value. Because, since RMB v36.0.0, the FileDefinition.sourcePath field, which is defined as a read-only field, comes as null to the endpoint logic

Learning

MODDATAIMP-1234

Comment thread src/main/java/org/folio/rest/impl/DataImportImpl.java Outdated
Comment thread src/main/java/org/folio/rest/impl/ModTenantAPI.java Outdated
Comment thread src/main/java/org/folio/service/file/SplitFileProcessingService.java Outdated
@sonarqubecloud
Copy link
Copy Markdown

@RuslanLavrov RuslanLavrov merged commit 0991c9f into master Mar 27, 2026
4 checks passed
@RuslanLavrov RuslanLavrov deleted the MODDATAIMP-1234 branch March 27, 2026 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants