Conversation
cbcd7d1 to
97b8c13
Compare
foca
left a comment
There was a problem hiding this comment.
Thanks so much for taking the time and effort to do this! ❤️
Could you add tests for this? If not I'll get around to it probably over the weekend, but would like to merge with tests added.
|
I'm really not that sure I could write a simple test around this - if you can come up with them, that'd be great 👍 |
|
I added some tests and documentation on top of your changes on this branch. Feel free to pull them into the PR and I'll merge it 😄 |
|
I also added a tiny performance improvement on top of your change, to avoid adding files to the search path, just directories. This way we pay a tiny penalty (checking if it's a directory) once when adding them to the path, but avoid iterating through a list with potentially lots of files each time you include another one. |
Fixes #1