fix: migrate payment profiles to MUI components #925
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,150 @@ | ||
| import configureStore from "redux-mock-store"; | ||
| import thunk from "redux-thunk"; | ||
| import flushPromises from "flush-promises"; | ||
| import { getRequest } from "openstack-uicore-foundation/lib/utils/actions"; | ||
| import { getPaymentProfiles } from "../ticket-actions"; | ||
| import * as methods from "../../utils/methods"; | ||
|
|
||
| jest.mock("openstack-uicore-foundation/lib/utils/actions", () => ({ | ||
| __esModule: true, | ||
| ...jest.requireActual("openstack-uicore-foundation/lib/utils/actions"), | ||
| getRequest: jest.fn() | ||
| })); | ||
|
|
||
| describe("getPaymentProfiles", () => { | ||
| const middlewares = [thunk]; | ||
| const mockStore = configureStore(middlewares); | ||
| const SUMMIT_ID = 42; | ||
| let store; | ||
| let capturedParams; | ||
|
|
||
| beforeEach(() => { | ||
| jest.clearAllMocks(); | ||
| capturedParams = null; | ||
| store = mockStore({ | ||
| currentSummitState: { currentSummit: { id: SUMMIT_ID } } | ||
| }); | ||
| jest.spyOn(methods, "getAccessTokenSafely").mockResolvedValue("TOKEN"); | ||
| window.PURCHASES_API_URL = "https://purchases.example.com"; | ||
|
|
||
| getRequest.mockImplementation( | ||
| (reqAC, recAC, url, errHandler, extraPayload) => (params) => { | ||
| capturedParams = params; | ||
| return (dispatch) => { | ||
| dispatch(reqAC(extraPayload || {})); | ||
| return Promise.resolve().then(() => { | ||
| dispatch( | ||
| recAC({ | ||
| response: { | ||
| data: [], | ||
| total: 0, | ||
| current_page: 1, | ||
| last_page: 1 | ||
| } | ||
| }) | ||
| ); | ||
| }); | ||
| }; | ||
| } | ||
| ); | ||
| }); | ||
|
|
||
| afterEach(() => { | ||
| jest.restoreAllMocks(); | ||
| delete window.PURCHASES_API_URL; | ||
| }); | ||
|
|
||
| test("dispatches START_LOADING, REQUEST, RECEIVE, STOP_LOADING", async () => { | ||
| store.dispatch(getPaymentProfiles()); | ||
| await flushPromises(); | ||
|
|
||
| const types = store.getActions().map((a) => a.type); | ||
| expect(types).toEqual([ | ||
| "START_LOADING", | ||
| "REQUEST_PAYMENT_PROFILES", | ||
| "RECEIVE_PAYMENT_PROFILES", | ||
| "STOP_LOADING" | ||
| ]); | ||
| expect(getRequest).toHaveBeenCalledTimes(1); | ||
| }); | ||
|
|
||
| test("builds correct summit URL", async () => { | ||
| store.dispatch(getPaymentProfiles()); | ||
| await flushPromises(); | ||
|
|
||
| const url = getRequest.mock.calls[0][2]; | ||
| expect(url).toBe( | ||
| `https://purchases.example.com/api/v1/summits/${SUMMIT_ID}/payment-profiles` | ||
| ); | ||
| }); | ||
|
|
||
| test.each(["", undefined])("omits filter[] when term is %p", async (term) => { | ||
| store.dispatch(getPaymentProfiles(term)); | ||
| await flushPromises(); | ||
|
|
||
| expect(capturedParams).not.toHaveProperty("filter[]"); | ||
| }); | ||
|
|
||
| test("adds filter[] array with provider, id, application_type for non-empty term", async () => { | ||
| store.dispatch(getPaymentProfiles("stripe")); | ||
| await flushPromises(); | ||
|
|
||
| expect(capturedParams["filter[]"]).toEqual([ | ||
| "provider=@stripe,id=@stripe,application_type=@stripe" | ||
| ]); | ||
| }); | ||
|
|
||
| test.each([ | ||
| [ | ||
| "foo,bar", | ||
| "provider=@foo\\,bar,id=@foo\\,bar,application_type=@foo\\,bar" | ||
| ], | ||
| ["foo;bar", "provider=@foo\\;bar,id=@foo\\;bar,application_type=@foo\\;bar"] | ||
| ])( | ||
| "escapeFilterValue escapes special chars in %p", | ||
| async (term, expected) => { | ||
| store.dispatch(getPaymentProfiles(term)); | ||
| await flushPromises(); | ||
|
|
||
| expect(capturedParams["filter[]"]).toEqual([expected]); | ||
| } | ||
| ); | ||
|
|
||
| test("REQUEST_PAYMENT_PROFILES payload includes term, page, perPage, order, orderDir", async () => { | ||
| store.dispatch(getPaymentProfiles("stripe", 2, 25, "provider", 0)); | ||
| await flushPromises(); | ||
|
|
||
| const extraPayload = getRequest.mock.calls[0][4]; | ||
| expect(extraPayload).toEqual({ | ||
| term: "stripe", | ||
| page: 2, | ||
| perPage: 25, | ||
| order: "provider", | ||
| orderDir: 0 | ||
| }); | ||
| }); | ||
|
|
||
| test("params include access_token, page, and per_page", async () => { | ||
| store.dispatch(getPaymentProfiles("", 3, 20)); | ||
| await flushPromises(); | ||
|
|
||
| expect(capturedParams).toMatchObject({ | ||
| access_token: "TOKEN", | ||
| page: 3, | ||
| per_page: 20 | ||
| }); | ||
| }); | ||
|
|
||
| test.each([ | ||
| [1, "+provider"], | ||
| [0, "-provider"] | ||
| ])( | ||
| "order param uses correct prefix for orderDir %i", | ||
| async (orderDir, expected) => { | ||
| store.dispatch(getPaymentProfiles("", 1, 10, "provider", orderDir)); | ||
| await flushPromises(); | ||
|
|
||
| expect(capturedParams.order).toBe(expected); | ||
| } | ||
| ); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 [MEDIUM] Missing test coverage for the new behavior
No
__tests__updates ship with this PR for any of the new surfaces. The following should be covered before merge:getPaymentProfileswithterm— URL/params construction with non-emptyterm(verifyescapeFilterValue, thefilter[]array shape, and the newREQUEST_PAYMENT_PROFILESpayload).REQUEST_PAYMENT_PROFILES— asserts thatterm,currentPage,perPageland in state (catches the bug flagged inpayment-profile-list-reducer.js#L46).PaymentProfileDialogflow —payment-profile-list-page.js#L110),.catchbehaviour),This is a UX-critical surface (payment configuration). At minimum the action + reducer should be covered.