Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
107 changes: 107 additions & 0 deletions src/actions/__tests__/selection-plan-actions.test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,107 @@
/**
* @jest-environment jsdom
*/
import configureStore from "redux-mock-store";
import thunk from "redux-thunk";
import flushPromises from "flush-promises";
import {
postRequest,
putRequest
} from "openstack-uicore-foundation/lib/utils/actions";
import { saveSelectionPlan } from "../selection-plan-actions";
import * as methods from "../../utils/methods";

jest.mock("openstack-uicore-foundation/lib/utils/actions", () => ({
__esModule: true,
...jest.requireActual("openstack-uicore-foundation/lib/utils/actions"),
postRequest: jest.fn(),
putRequest: jest.fn()
}));

jest.mock("../marketing-actions", () => ({
saveMarketingSetting: jest.fn()
}));

const requestMock =
(requestActionCreator, receiveActionCreator) => () => (dispatch) => {
if (requestActionCreator && typeof requestActionCreator === "function") {
dispatch(requestActionCreator({}));
}
return new Promise((resolve) => {
if (typeof receiveActionCreator === "function") {
dispatch(receiveActionCreator({ response: { id: 1 } }));
} else {
dispatch(receiveActionCreator);
}
resolve({ response: { id: 1 } });
});
};

const storeState = {
currentSummitState: { currentSummit: { id: 1 } }
};

describe("saveSelectionPlan", () => {
const middlewares = [thunk];
const mockStore = configureStore(middlewares);

beforeEach(() => {
jest.spyOn(methods, "getAccessTokenSafely").mockResolvedValue("TOKEN");
postRequest.mockImplementation(requestMock);
putRequest.mockImplementation(requestMock);
});

afterEach(() => {
jest.restoreAllMocks();
});

describe("create path (entity has no id)", () => {
it("returns a Promise that resolves with the response payload", async () => {
const store = mockStore(storeState);
const result = store.dispatch(
saveSelectionPlan({ name: "CFP 2026", is_enabled: true })
);
expect(result).toBeInstanceOf(Promise);
await expect(result).resolves.toEqual({ id: 1 });
});

it("dispatches SELECTION_PLAN_ADDED then STOP_LOADING on success", async () => {
const store = mockStore(storeState);
store.dispatch(saveSelectionPlan({ name: "CFP 2026", is_enabled: true }));
await flushPromises();

const actionTypes = store.getActions().map((a) => a.type);
expect(actionTypes).toContain("SELECTION_PLAN_ADDED");
expect(actionTypes).toContain("STOP_LOADING");
expect(actionTypes.indexOf("STOP_LOADING")).toBeGreaterThan(
actionTypes.indexOf("SELECTION_PLAN_ADDED")
);
});
});

describe("update path (entity has id)", () => {
it("returns a Promise that resolves with the response payload", async () => {
const store = mockStore(storeState);
const result = store.dispatch(
saveSelectionPlan({ id: 1, name: "CFP 2026", is_enabled: true })
);
expect(result).toBeInstanceOf(Promise);
await expect(result).resolves.toEqual({ id: 1 });
});

it("dispatches SELECTION_PLAN_UPDATED then STOP_LOADING on success", async () => {
const store = mockStore(storeState);
store.dispatch(
saveSelectionPlan({ id: 1, name: "CFP 2026", is_enabled: true })
);
await flushPromises();

const actionTypes = store.getActions().map((a) => a.type);
expect(actionTypes).toContain("SELECTION_PLAN_UPDATED");
expect(actionTypes).toContain("STOP_LOADING");
expect(actionTypes.indexOf("STOP_LOADING")).toBeGreaterThan(
actionTypes.indexOf("SELECTION_PLAN_UPDATED")
);
});
});
});
66 changes: 42 additions & 24 deletions src/actions/selection-plan-actions.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
* */

import T from "i18n-react/dist/i18n-react";
import debounce from "lodash/debounce"
import debounce from "lodash/debounce";
import {
getRequest,
putRequest,
Expand All @@ -35,7 +35,12 @@ import {
fetchErrorHandler
} from "../utils/methods";
import { saveMarketingSetting } from "./marketing-actions";
import { DEBOUNCE_WAIT, DEFAULT_PER_PAGE } from "../utils/constants";
import {
DEBOUNCE_WAIT,
DEFAULT_CURRENT_PAGE,
DEFAULT_ORDER_DIR,
DEFAULT_PER_PAGE
} from "../utils/constants";

URI.escapeQuerySpace = false;

Expand Down Expand Up @@ -66,7 +71,13 @@ export const SELECTION_PLAN_PROGRESS_FLAG_ORDER_UPDATED =
"SELECTION_PLAN_PROGRESS_FLAG_ORDER_UPDATED";

export const getSelectionPlans =
(term = "", page = 1, order = "id", orderDir = 1) =>
(
term = "",
page = DEFAULT_CURRENT_PAGE,
perPage = DEFAULT_PER_PAGE,
order = "id",
orderDir = DEFAULT_ORDER_DIR
) =>
async (dispatch, getState) => {
const { currentSummitState } = getState();
const accessToken = await getAccessTokenSafely();
Expand All @@ -84,7 +95,7 @@ export const getSelectionPlans =
access_token: accessToken,
relations: "none",
page,
per_page: DEFAULT_PER_PAGE,
per_page: perPage,
order: `${orderDir === 1 ? "" : "-"}${order}`
};

Expand All @@ -93,10 +104,11 @@ export const getSelectionPlans =
}

return getRequest(
null,
createAction(REQUEST_SELECTION_PLANS),
createAction(RECEIVE_SELECTION_PLANS),
`${window.API_BASE_URL}/api/v1/summits/${currentSummit.id}/selection-plans`,
authErrorHandler
authErrorHandler,
{ order, orderDir, page, perPage, term }
)(params)(dispatch).then(async () => {
dispatch(stopLoading());
});
Expand Down Expand Up @@ -151,15 +163,18 @@ export const saveSelectionPlan = (entity) => async (dispatch, getState) => {
normalizedEntity,
authErrorHandler,
entity
)({})(dispatch).then((payload) => {
dispatch(stopLoading());
dispatch(
showSuccessMessage(
T.translate("edit_selection_plan.selection_plan_saved")
)
);
return payload.response;
});
)({})(dispatch)
.then((payload) => {
dispatch(
showSuccessMessage(
T.translate("edit_selection_plan.selection_plan_saved")
)
);
return payload.response;
})
.finally(() => {
dispatch(stopLoading());
});
}
return postRequest(
createAction(UPDATE_SELECTION_PLAN),
Expand All @@ -168,15 +183,18 @@ export const saveSelectionPlan = (entity) => async (dispatch, getState) => {
normalizedEntity,
authErrorHandler,
entity
)({})(dispatch).then((payload) => {
dispatch(stopLoading());
dispatch(
showSuccessMessage(
T.translate("edit_selection_plan.selection_plan_created")
)
);
return payload.response;
});
)({})(dispatch)
.then((payload) => {
dispatch(
showSuccessMessage(
T.translate("edit_selection_plan.selection_plan_created")
)
);
return payload.response;
})
.finally(() => {
dispatch(stopLoading());
});
};

export const deleteSelectionPlan =
Expand Down
Loading
Loading