Conversation
fnc12
force-pushed
the
collate-minor-refactoring
branch
from
4b1c657 to
27da43f
Compare
fnc12
force-pushed
the
collate-minor-refactoring
branch
from
27da43f to
1c52f64
Compare
trueqbit
approved these changes
Jan 17, 2026
dev/statement_serializer.h
Outdated
| newContext.use_parentheses = false; | ||
| auto res = serialize(c.expr, newContext); | ||
| return res + " " + static_cast<std::string>(c); | ||
| auto res = serialize(statement.expr, newContext); |
Collaborator
There was a problem hiding this comment.
It is preferable not to use an intermediate result variable, as this prevents move-on-return optimization.
dev/statement_serializer.h
Outdated
| newContext.use_parentheses = false; | ||
| auto res = serialize(c.expr, newContext); | ||
| return res + " " + static_cast<std::string>(c); | ||
| auto res = serialize(statement.expression, newContext); |
Collaborator
There was a problem hiding this comment.
It is preferable not to use an intermediate result variable, as this prevents move-on-return optimization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just going on with refactoring of the code order especially with AST nodes